Line 242 of OverviewTerms.php results in 'taxonomy/term/()' always being returned.

Files: 
CommentFileSizeAuthor
#6 1998258-6-taxonomy-term-overview-link-pass.patch1.57 KBnick_schuch
PASSED: [[SimpleTest]]: [MySQL] 57,555 pass(es).
[ View ]
#2 1998258-2-taxonomy-term-overview-link-fail.patch867 bytesnick_schuch
FAILED: [[SimpleTest]]: [MySQL] 55,611 pass(es), 1 fail(s), and 0 exception(s).
[ View ]
#2 1998258-2-taxonomy-term-overview-link-pass.patch1.57 KBnick_schuch
PASSED: [[SimpleTest]]: [MySQL] 55,813 pass(es).
[ View ]

Comments

I have tried to find an active issue but cannot. Currently writing tests.

StatusFileSize
new1.57 KB
PASSED: [[SimpleTest]]: [MySQL] 55,813 pass(es).
[ View ]
new867 bytes
FAILED: [[SimpleTest]]: [MySQL] 55,611 pass(es), 1 fail(s), and 0 exception(s).
[ View ]

I have supplied 2 patches. One to confirm the fail and another to fix it.

Status:Active» Needs review

Status:Needs review» Reviewed & tested by the community

Yeah, I broke that :(

looks good.

Status:Reviewed & tested by the community» Needs work

Oh, not quite yet.

+++ b/core/modules/taxonomy/lib/Drupal/taxonomy/Tests/TermTest.phpundefined
@@ -323,6 +323,10 @@ function testTermInterface() {
+    $this->assertResponse(200, 'Term page can be accessessed via the listing link.');

a few s and e's too much :)

Status:Needs work» Needs review
StatusFileSize
new1.57 KB
PASSED: [[SimpleTest]]: [MySQL] 57,555 pass(es).
[ View ]

Oh! Woops :)

Status:Needs review» Reviewed & tested by the community

Now we're good. Let's get this in.

Status:Reviewed & tested by the community» Fixed

Nice catch and nice to have a test...

Committed 68ee461 and pushed to 8.x. Thanks!

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.