Remove ajaxPageState settings if they're not needed

#1 Patch looks good

+++ b/template.phpundefined
@@ -315,6 +315,20 @@ function omega_css_alter(&$css) {
+  if ( ! isset($js['misc/ajax.js']) && isset($js['settings']['data'])) {

no space after !

PS: Can you have a look at #1279226: jQuery and Drupal JavaScript libraries and settings are output even when no JS is added to the page it will add major improvements on mobile

I have a site which makes heavy use of the AJAX commands and AJAX in the FAPI. Assigning to me so I remember to review this at some point.

Let's do this. Just tried it and seems to work. Can you take a final look @splatio and then commit it?

Works great for me. Committed in b3c106c and pushed.

Thanks!

Nope, this does not work. This currently causes a bug with the Edit module. This is a very rare case but we CAN'T just remove this stuff as it seems to be required when a script adds JavaScript file as a result of the Ajax response.

So, reverting this :).

Reverted in commit 9705213.

If you find a better way of doing this without breaking modules like Edit, please provide a new patch!

Otherwise, please close as "Won't fix"

I've tested this with Quickedit (the renamed Edit module) and can confirm the patch in #8 does not break it. Even if this isn't committed, I would recommend doing a new release now so that Omega and Quickedit are compatible with non-dev versions (the original patch was reverted after 4.2).

Thanks

Not exactly sure how but I believe this is breaking views ajax requests on my site because this didn't happen before the update.

It may only happen with views caching, I'll report back if I have more details.

An error occurred while attempting to process /ca/views/ajax: ajax.form.ajaxSubmit is not a function

This causes all ajax to fail if using the Dialog API module. The Dialog API is looking for these settings that have been removed and everything falls apart.

I'm not sure what the original reasoning for removing these settings was other than just keeping things clean. Perhaps this is a little too heavy handed? I would recommend removing this patch if it doesn't really provide any benefits in regard to performance.

TypeError: Drupal.settings.ajaxPageState is undefined
options.data['ajax_page_state[theme]'] = Drupal.settings.ajaxPageState.theme;

We never rolled this back. @fubhy do you have time to comment?

Just verifying that reverting the patch in #8 fixes the incompatibility with the Dialog API.

Dialog API isn't the only affected module. File Field and Drag'n Drop upload also displayed errors:

"cannot read property 'theme' of undefined" (Chrome)
- or -
"TypeError: Drupal.settings.ajaxPageState is undefined" (Firefox)

when trying to execute an ajax request. Commenting out (reverting) the patched lines in omega/template.php fixed the errors and made the functions usable.

Both errors are from the same page and the same field.

These settings are used by the scheduler module as well.

scheduler_vertical_tabs.js?:19 Uncaught TypeError: Cannot read property 'theme' of undefined

I can confirm that the patch #8 is breaking views ajax requests, in views exposed filters.

The errors displayed are:

cannot read property 'theme' of undefined (Chrome)
TypeError: Drupal.settings.ajaxPageState is undefined (Firefox)

Reverting the patch in #8 fixes the incompatibility.

Took me a very long time to figure out this was the cause of all my problems! Views exposed filters as well as file/image upload fields were just not working.... getting the above errors like everyone else:

cannot read property 'theme' of undefined (Chrome)
TypeError: Drupal.settings.ajaxPageState is undefined (Firefox)

Reverting the changes in patch #8 solved my problems