A translator will be used to the string translation where he has the source on the left and the translation on the right.
To make the experience with config translation more unified attached a patch which changes the UI for translation of configuration to a left/right source/translation base.

attached screenshot shows how it looks

CommentFileSizeAuthor
#7 d8mi-config-trans-full-width.png64.55 KBKristen Pol
#7 d8mi-config-trans-responsive.png71.79 KBKristen Pol
#5 1998528-translation-ui-5.patch10.54 KBSchnitzel
#1 1998528-translation-ui-2.patch5.89 KBSchnitzel
19.05.13_13_13-Bildschirmkopie.jpg708.3 KBSchnitzel
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Schnitzel’s picture

Schnitzel CreditAttribution: Schnitzel commented
Status: Active » Needs review
FileSize
1998528-translation-ui-2.patch5.89 KB

Status: Needs review » Needs work

The last submitted patch, 1998528-translation-ui-2.patch, failed testing.

victor-shelepen’s picture

victor-shelepen CreditAttribution: victor-shelepen commented

How to attach the translation posibility to a custom settings form?

Schnitzel’s picture

Schnitzel CreditAttribution: Schnitzel commented

@likin
mhh this question does not really have to do with this issue ;)
please open another issue if you've got a question. thanks!

Schnitzel’s picture

Schnitzel CreditAttribution: Schnitzel commented
FileSize
1998528-translation-ui-5.patch10.54 KB

oops, forgot to adapt the tests with the new Form Structure, this is fixed now

Schnitzel’s picture

Schnitzel CreditAttribution: Schnitzel commented
Status: Needs work » Needs review
Kristen Pol’s picture

Kristen Pol
she/her
Primary language English
Location Santa Cruz, CA, USA
CreditAttribution: Kristen Pol commented
FileSize
d8mi-config-trans-responsive.png71.79 KB
d8mi-config-trans-full-width.png64.55 KB

I've tested and it looks pretty good. I'm not sure how clever it needs to be in terms of the textarea height at full width (it's pretty close to what it needs to be):

d8mi-config-trans-full-width.png

and the height at narrow width (for mobile):

d8mi-config-trans-responsive.png

Is "close" good enough for the full width? Do we need to deal with mobile? If so, should it be its own issue?

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Status: Needs review » Fixed

I committed this as-is for now. Let's do a followup for the responsive layout.

Schnitzel’s picture

Schnitzel CreditAttribution: Schnitzel commented

Follow up for Responsive: #1999156: Responsive Configuration Translation UI

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.