Follow-up after #1875992: Add EntityFormDisplay objects for entity forms

CommentFileSizeAuthor
#12 1998992-12.patch2.06 KBdamiankloip
#12 interdiff-1998992-12.txt1.16 KBdamiankloip
#4 1998992-4-test-only.patch1.2 KBdamiankloip
#4 1998992-4.patch2.08 KBdamiankloip
#1 1998992-typo-1.patch907 bytesandypost
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented
Status: Active » Needs review
FileSize
1998992-typo-1.patch907 bytes

probably needs test

amateescu’s picture

amateescu CreditAttribution: amateescu commented
Status: Needs review » Reviewed & tested by the community

I wouldn't bother with a test for this :/

swentel’s picture

swentel CreditAttribution: swentel commented

damiankloip is working on a test actually.

damiankloip’s picture

damiankloip CreditAttribution: damiankloip commented
Status: Reviewed & tested by the community » Needs review
FileSize
1998992-4.patch2.08 KB
1998992-4-test-only.patch1.2 KB

I think we should have a test :) and it only takes 5 mins. Here is the test and combined.

swentel’s picture

swentel CreditAttribution: swentel commented
Status: Needs review » Reviewed & tested by the community

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 1998992-4.patch, failed testing.

swentel’s picture

swentel CreditAttribution: swentel commented
Status: Needs work » Needs review

Hrm, actually, shouldn't we go to the field admin overview ?
Also you can chain entity_get_form_display()->remove->save().

damiankloip’s picture

damiankloip CreditAttribution: damiankloip commented

#4: 1998992-4.patch queued for re-testing.

swentel’s picture

swentel CreditAttribution: swentel commented

Nevermind, it's ok, seriously.

swentel’s picture

swentel CreditAttribution: swentel commented
Status: Needs review » Reviewed & tested by the community
Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented

#569434: Remove taxonomy term description field; provide description field for forum taxonomy is triggering this, so it adds additional test coverage for this and is blocked on it right now :)

damiankloip’s picture

damiankloip CreditAttribution: damiankloip commented
Status: Reviewed & tested by the community » Needs review
FileSize
interdiff-1998992-12.txt1.16 KB
1998992-12.patch2.06 KB

We don't need to assign entity_get_form_display to a variable.

swentel’s picture

swentel CreditAttribution: swentel commented
Status: Needs review » Reviewed & tested by the community

Better, thanks!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed 2de1370 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.