Part of #1998638: Replace almost all remaining superglobals ($_GET, $_POST, etc.) with Symfony Request object

Files that need converting are:

  • core/modules/image/image.admin.inc
  • core/modules/image/image.module
CommentFileSizeAuthor
#7 convert-image-to-symfony-request-1999384-7.patch1.58 KBAnonymous (not verified)
#7 interdiff-1-6.txt1.64 KBAnonymous (not verified)
#1 1999384-convert-image-to-symfony-request-1.patch1.64 KBbojanz
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

bojanz’s picture

bojanz CreditAttribution: bojanz commented
Status: Active » Needs review
FileSize
1999384-convert-image-to-symfony-request-1.patch1.64 KB

Wow, this module has ugly logic. I mean, nested ternary operators?!

Status: Needs review » Needs work

The last submitted patch, 1999384-convert-image-to-symfony-request-1.patch, failed testing.

arknoll’s picture

arknoll CreditAttribution: arknoll commented
Assigned: Unassigned » arknoll

looking into why this patch failed.

arknoll’s picture

arknoll CreditAttribution: arknoll commented
Status: Needs work » Needs review

#1: 1999384-convert-image-to-symfony-request-1.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, 1999384-convert-image-to-symfony-request-1.patch, failed testing.

kim.pepper’s picture

kim.pepper
Primary language English
Location 🏄‍♂️🇦🇺Sydney, Australia
CreditAttribution: kim.pepper commented

Are you still working on this arknoll?

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
FileSize
interdiff-1-6.txt1.64 KB
convert-image-to-symfony-request-1999384-7.patch1.58 KB

Reroll the #1 patch Needs Review

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
Status: Needs work » Needs review

Change status to Needs Review

Crell’s picture

Crell CreditAttribution: Crell commented
Status: Needs review » Reviewed & tested by the community

Thanks, naveenvalecha!

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Reviewed & tested by the community » Fixed

Committed to 8.x. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.