Part of #1998638: Replace almost all remaining superglobals ($_GET, $_POST, etc.) with Symfony Request object

Files that need converting are:

  • core/modules/menu/menu.module
Files: 
CommentFileSizeAuthor
#1 1999398_1-replace-raw-variables-menu.patch615 byteschertzog
PASSED: [[SimpleTest]]: [MySQL] 55,891 pass(es).
[ View ]

Comments

Assigned:Unassigned» chertzog
Status:Active» Needs review
StatusFileSize
new615 bytes
PASSED: [[SimpleTest]]: [MySQL] 55,891 pass(es).
[ View ]

Looks good. RTBC from me.

Status:Needs review» Reviewed & tested by the community

Issue tags:+Quick fix

Tagging.

Status:Reviewed & tested by the community» Fixed

Committed b90377b and pushed to 8.x. Thanks!

For future reference, PHP's count() function is only useful if you want to know the specific number of items of a thing you know is countable.

Because if you call count(NULL), it will return 1. Yes. I'm serious, it's awful.

This whole thing was already fixed in #1984702: Convert menu.module's page callbacks to Controllers, I'll just reroll that.

Automatically closed -- issue fixed for 2 weeks with no activity.