Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Files that need converting are:
- core/modules/overlay/overlay.module
Comment | File | Size | Author |
---|---|---|---|
#13 | 1999408-overlay-request.patch | 697 bytes | kim.pepper |
#13 | interdiff.txt | 694 bytes | kim.pepper |
#11 | drupal-use_symfony_request_fro_overlay_module-1999408-11.patch | 649 bytes | Anonymous (not verified) |
#6 | drupal-use_symfony_request_fro_overlay_module-1999408-4.patch | 792 bytes | Anonymous (not verified) |
#2 | drupal-use_symfony_request_fro_overlay_module-1999408-2.patch | 1.64 KB | atchijov |
Comments
Comment #1
atchijov CreditAttribution: atchijov commentedatchijov & johnbickar working on this.
Comment #2
atchijov CreditAttribution: atchijov commentedComment #3
atchijov CreditAttribution: atchijov commentedComment #4
atchijov CreditAttribution: atchijov commentedComment #5
kim.pepperMaybe rename this to $render?
Let's extract a $query variable to be re-used.
Comment #6
Anonymous (not verified) CreditAttribution: Anonymous commentedReroll the patch as the hook_init removed https://drupal.org/node/2013014.
Comment #7
Crell CreditAttribution: Crell commentedI have no idea what black magic overlay is trying to do here, but at least this way it's doing it with the right API. :-)
Thanks!
Comment #8
Dries CreditAttribution: Dries commentedSeems like this needs a re-roll.
Comment #9
Dries CreditAttribution: Dries commented#6: drupal-use_symfony_request_fro_overlay_module-1999408-4.patch queued for re-testing.
Comment #11
Anonymous (not verified) CreditAttribution: Anonymous commentedActually this code already committed.
Now I Reroll the patch #6.So please Needs Review.
Comment #12
Crell CreditAttribution: Crell commentedrequest()->query is the GET parameters. You want the POST parameters, which I believe are request()->request->count().
Comment #13
kim.pepperFixes #12
Comment #14
Crell CreditAttribution: Crell commentedThat looks better. Thanks!
Comment #15
alexpottCommitted 9d61e24 and pushed to 8.x. Thanks!