Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Files that need converting are:
- core/modules/user/lib/Drupal/user/AccountFormController.php
- core/modules/user/user.admin.inc
- core/modules/user/user.pages.inc
Comment | File | Size | Author |
---|---|---|---|
#17 | 1999448-user-request-17.patch | 1.63 KB | kim.pepper |
#17 | interdiff.txt | 954 bytes | kim.pepper |
#13 | 1999448-interdiff-13.txt | 964 bytes | aaronott |
#13 | 1999448-13-replace-raw-variables-user.patch | 1.65 KB | aaronott |
#10 | 1999448-10-replace-raw-variables-user.patch | 1.68 KB | aaronott |
Comments
Comment #1
chertzogI think i got all of them.
Comment #3
chertzogfixes
Comment #4
kim.pepperLooking good. Needs a bit of clean up.
Should probably call this $token or $reset_token instead of $request
Again, variable name $request doesn't quite match.
You turn this into an if statement and it would be more readable.
Extract the $request variable here to make it less verbose.
The variable should probably be called $destination
Comment #5
chrisjlee CreditAttribution: chrisjlee commentedattempt a reroll.
Comment #6
chrisjlee CreditAttribution: chrisjlee commented...
Comment #8
Anonymous (not verified) CreditAttribution: Anonymous commentedReroll this one Go testbot go !
Comment #10
aaronott CreditAttribution: aaronott commentedAnother re-roll with small changes such as using ->has() instead of isset().
Comment #11
kim.pepperLooks good to me!
Comment #12
alexpottWe don't need the ->has() here... ->get() will return NULL. Due to the
isset($_SESSION['pass_reset_' . $account->uid])
the value we test against can never be NULLComment #13
aaronott CreditAttribution: aaronott commentedGood point!
I've removed the ->has() from AccountFormController.
Comment #14
Anonymous (not verified) CreditAttribution: Anonymous commentedlooks good to me.I think it should go to RTBC +1
Comment #15
Anonymous (not verified) CreditAttribution: Anonymous commented#13: 1999448-13-replace-raw-variables-user.patch queued for re-testing.
Comment #17
kim.pepperRemoved an unnecessary $query variable.
Comment #18
dawehnerLooks perfect!
Comment #19
Dries CreditAttribution: Dries commentedCommitted to 8.x. Thanks!