Files: 
CommentFileSizeAuthor
#7 views-core-add_additional_fields-2001318-7.patch6.28 KBDan Reinders
PASSED: [[SimpleTest]]: [MySQL] 55,604 pass(es).
[ View ]
#5 2001318-05-views-add_additional_fields-rename.patch1.04 KBDan Reinders
FAILED: [[SimpleTest]]: [MySQL] 57,566 pass(es), 4 fail(s), and 0 exception(s).
[ View ]
views-add_additional_fields-rename.patch1.03 KBchertzog
FAILED: [[SimpleTest]]: [MySQL] 55,653 pass(es), 4 fail(s), and 0 exception(s).
[ View ]

Comments

Status:Needs review» Needs work

The last submitted patch, views-add_additional_fields-rename.patch, failed testing.

Status:Needs work» Needs review
Issue tags:+Novice, +VDC

Status:Needs review» Needs work

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/field/FieldPluginBase.phpundefined
@@ -115,7 +115,7 @@ public function query() {
+  function addAdditionalFields($fields = NULL) {

Add protected access modifier in front of the method to adher to the new OOP standards.

Status:Needs work» Needs review

StatusFileSize
new1.04 KB
FAILED: [[SimpleTest]]: [MySQL] 57,566 pass(es), 4 fail(s), and 0 exception(s).
[ View ]

added protected keyword

Status:Needs review» Needs work

The last submitted patch, 2001318-05-views-add_additional_fields-rename.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new6.28 KB
PASSED: [[SimpleTest]]: [MySQL] 55,604 pass(es).
[ View ]

Found additional instances of add_additional_fields that needed to be fixed.

Status:Needs review» Needs work
Issue tags:-Novice, -VDC

The last submitted patch, views-core-add_additional_fields-2001318-7.patch, failed testing.

Status:Needs work» Needs review
Issue tags:+Novice, +VDC

Status:Needs review» Reviewed & tested by the community

Looks good to me now !

Status:Reviewed & tested by the community» Fixed

Committed and pushed to 8.x. Thanks!

Title:Rename Views method add_additional_fields() to addAdditionalFields()[Change notice] Rename Views method add_additional_fields() to addAdditionalFields()
Project:Drupal core» Views
Version:8.x-dev» 8.x-3.x-dev
Component:views.module» Code
Status:Fixed» Active
Issue tags:+Needs change record

Oops. Needs a change notice.

Title:[Change notice] Rename Views method add_additional_fields() to addAdditionalFields()Rename Views method add_additional_fields() to addAdditionalFields()
Project:Views» Drupal core
Version:8.x-3.x-dev» 8.x-dev
Component:Code» views.module
Assigned:chertzog» Unassigned
Status:Active» Fixed
Issue tags:-Needs change record

Automatically closed -- issue fixed for 2 weeks with no activity.