Rename Views method add_having_expression() to addHavingExpression()

Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards

Files: 
CommentFileSizeAuthor
#13 views-add_having_expression-rename-2001330.patch5.38 KBjuan.brein
PASSED: [[SimpleTest]]: [MySQL] 55,812 pass(es).
[ View ]
#8 views-add_having_expression-rename-2001330.patch6.09 KBzschmid
Test request sent.
Previous result: FAILED: [[SimpleTest]]: [MySQL] 55,874 pass(es), 1 fail(s), and 0 exception(s).
[ View ]
#7 views-add_having_expression-rename.patch-7.patch5.38 KBKCarlile
PASSED: [[SimpleTest]]: [MySQL] 55,908 pass(es).
[ View ]
#2 views-add_having_expression-rename-2001330.patch5.38 KBjuan.brein
PASSED: [[SimpleTest]]: [MySQL] 55,924 pass(es).
[ View ]
views-add_having_expression-rename.patch4.56 KBchertzog
FAILED: [[SimpleTest]]: [MySQL] 55,882 pass(es), 2 fail(s), and 0 exception(s).
[ View ]

Comments

Status:Needs review» Needs work

The last submitted patch, views-add_having_expression-rename.patch, failed testing.

Assigned:chertzog» juan.brein
Status:Needs work» Needs review
StatusFileSize
new5.38 KB
PASSED: [[SimpleTest]]: [MySQL] 55,924 pass(es).
[ View ]

Hope you don't mind if I take this one. Starting to submit patches and I found this one pretty easy one.

My patch is attached

cheers

Juan

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/query/Sql.phpundefined
@@ -953,7 +953,7 @@ function add_having($group, $field, $value = NULL, $operator = NULL) {
+  function addHavingExpression($group, $snippet, $args = array()) {

Please make it public

Sorry don't quite understand what this last comment mean. Do you want me to apply this snippet and put the patch again?

@juan, he means to make this:

function addHavingExpression($group, $snippet, $args = array()) {

to

public function addHavingExpression($group, $snippet, $args = array()) {

Status:Needs review» Needs work

duplicate comment - safely ignore this :)

Status:Needs work» Needs review
StatusFileSize
new5.38 KB
PASSED: [[SimpleTest]]: [MySQL] 55,908 pass(es).
[ View ]

Renamed add_having_expression() to addHavingExpression() and made it public.

Assigned:juan.brein» zschmid
StatusFileSize
new6.09 KB
Test request sent.
Previous result: FAILED: [[SimpleTest]]: [MySQL] 55,874 pass(es), 1 fail(s), and 0 exception(s).
[ View ]

adding public function

Status:Needs review» Needs work
Issue tags:-Novice, -VDC

The last submitted patch, views-add_having_expression-rename-2001330.patch, failed testing.

Status:Needs work» Needs review
Issue tags:+Novice, +VDC

Hmm...I'm not sure why this patch failed. It's nearly identical to the previous one that passed, except for the "public" declaration. I'm very new to this (as in just started at Drupalcon today), so would anyone be able to help explain why this test failed? Thanks!

@KCarlile, I believe the test bots or the git server (d.o) is having issues. You can get more details on the failure by clicking on "view details" link to the right of the status.

When clicking on the last patch details, near the bottom of the page you will see:

[23:05:03] Encountered error on [checkout], details:
array (
'@reason' => 'failed to checkout from [git://git.drupal.org/project/drupal.git]',
)

That indicates the drupal.git project can not be checked out, for some reason. Hopefully the problem will dissipate soon.

StatusFileSize
new5.38 KB
PASSED: [[SimpleTest]]: [MySQL] 55,812 pass(es).
[ View ]

New patch

Status:Needs review» Needs work

The last submitted patch, views-add_having_expression-rename-2001330.patch, failed testing.

Assigned:zschmid» Unassigned
Status:Needs work» Needs review

Status:Needs review» Reviewed & tested by the community

Looks good

All good. Reviewed patch based on: http://drupal.org/node/1856630#comment-7450696

Status:Fixed» Reviewed & tested by the community

Committed b53df3c and pushed to 8.x. Thanks!

Status:Reviewed & tested by the community» Fixed

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue summary:View changes

Copied directly from core.drupalofficehours.org