Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Hi, i am using this theme on my site.
I see, that in template.php we initialize $node variable, but she not using.
Repeated on 7.x - 1.x and 7.x-2.x
Comment | File | Size | Author |
---|---|---|---|
#1 | unused-variable-2001382-1.patch | 622 bytes | Samvel |
Comments
Comment #1
Samvel CreditAttribution: Samvel commentedI created patch for this.
Now $node used instead $vars['node']
highrockmedia please check it. Thank you.
Comment #2
Samvel CreditAttribution: Samvel commentedComment #3
Danny EnglanderHi Thanks for the patch and good catch. I also had that variable repeated further down in a new dev I pushed yesterday so I fixed that too. I tested this on my local dev and it seems to be fine. I'll push a new release up to 1.x soon but 2.x will stay at dev for now with no release since it's in the very early stages of development.
Comment #4
Samvel CreditAttribution: Samvel commentedPlease set me author for commit by my patch, i will help you further with the development of the theme. I see a lot of places where you can optimize. Thank you.
Comment #5
Danny EnglanderHi Samvel, I tired several times to attribute your authorship but nothing worked. To me the documentation on this seems unclear as it did not work for me. I tried these:
... but each presented its own issues, none of which I could solve going round with it for an hour or so. Of course now I will have to change the old commit so I am not sure how to do that either.
I'm open to patches being submitted for 1.x but not against the 2.x dev right now, it's in its infancy and I am still sorting things out. Feel free to open an issue and supply patches or make feature requests. As you can see, this project is quite active and I pay a lot of attention to it.
Thanks, Danny
Comment #6
Samvel CreditAttribution: Samvel commentedI see that there are no closing quotes.
Please try this command:
git commit --author="asik <asik@1596146.no-reply.drupal.org>" -am "Issue #2001382 by Samvel: Unused $node variable in template.php"
It's good example of command and commit message.
Thank you.
Comment #7
Danny EnglanderThat didn't work as I got an error message that I could not push over what was there now so I relaized I had to ammend the commit. I tried:
... both seemed successful in committing part but still no joy after pushing, I get:
I tried git pull as suggested but still no joy after I pushed again, it simply showed the old commit message. This thread on stack seems to be what I am after but nothing worked to get the new amended message to push:
http://stackoverflow.com/questions/179123/how-do-i-edit-an-incorrect-com...
I'm out of ideas, sorry.
Comment #8.0
(not verified) CreditAttribution: commentedappend description