Here's the official project page over at github: https://github.com/brandonaaron/bgiframe

Comments

klonos’s picture

klonos
he/him
Primary language English
Location 90% Melbourne, Australia - 10% Larissa, Greece
CreditAttribution: klonos commented

...related: #2036601: Create a 7.x-3.x branch to support the latest versions of required js libraries - Keep 7.x-2.x compatible with default Drupal.

klonos’s picture

klonos
he/him
Primary language English
Location 90% Melbourne, Australia - 10% Larissa, Greece
CreditAttribution: klonos commented
Title: Upgrade included bgiframe library to 3.0.0 (currently shipping 2.1) » Upgrade included bgiframe library to 3.0.1 (currently shipping 3.0.0)
Version: 7.x-2.x-dev » 7.x-3.x-dev
Issue summary: View changes
Parent issue: » #2036601: Create a 7.x-3.x branch to support the latest versions of required js libraries - Keep 7.x-2.x compatible with default Drupal.

...new 7.x-3.x now includes bgiframe library 3.0.0, but before closing this issue, lets update it to the latest one released a couple of months ago:

https://raw.github.com/brandonaaron/bgiframe/master/jquery.bgiframe.js

klonos’s picture

klonos
he/him
Primary language English
Location 90% Melbourne, Australia - 10% Larissa, Greece
CreditAttribution: klonos commented

...btw, the library mentions that it requires jQuery >= 1.2.6, so this can work in 7.x-2.x too. Lets backport it for those still in 2.x

klonos’s picture

klonos
he/him
Primary language English
Location 90% Melbourne, Australia - 10% Larissa, Greece
CreditAttribution: klonos commented
Related issues: +#1411250: Upgrade included hoverIntent library to r7 (currently shipping r5), +#2001616: Upgrade included Superfish library to the latest version 1.7.4 (currently shipping 1.4.8)
xiukun.zhou’s picture

xiukun.zhou CreditAttribution: xiukun.zhou commented
Status: Active » Fixed

Thanks klonos.

7.x-2.x: c1d25c1
7.x-3.x: 81e5ccd

klonos’s picture

klonos
he/him
Primary language English
Location 90% Melbourne, Australia - 10% Larissa, Greece
CreditAttribution: klonos commented

Thanx Zhou! I'll be keeping an eye on the library for any new versions as they get released and when they do I'll be updating this issue ;)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

jwilson3’s picture

jwilson3
Primary language English
Location Ecuador
CreditAttribution: jwilson3 commented
Status: Closed (fixed) » Active

The commit c1d25c1b052a81c5b7a9f160ed3158992ca24b7f Issue #2001612 Upgrade included bgiframe library to 3.0.1 broke my site. I detected this doing a git bisect. One commit before this, drop-downs worked fine, but when I checkout this commit, the dropdowns never display.

The confounding thing is that the inline style on the sub-menu ul shows display:none;visibility:visible; on hover. Of course the sub-menu is never displayed because display:none overrides visibility:visible.

Reopening.

apaderno’s picture

apaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
CreditAttribution: apaderno commented
Status: Active » Fixed

If there are issues with the library used, please open a new issue.

apaderno’s picture

apaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
CreditAttribution: apaderno commented
Status: Fixed » Closed (fixed)