There still needs to be some performance improvements made on comment.html.twig.
Latest profiling data from http://drupal.org/node/1898054#comment-7430606
Scenario #1: Using Stark, devel generate a dozen or so nodes and set the "Maximum number of comments per node" to 30. Then set site front page to node with most comments (also, edit node comment settings to "open"). Comparing 8.x (6718550c) to #115.
=== 8.x..8.x compared (5199dd4798f9f..5199de96067c8):
ct : 143,205|143,205|0|0.0%
wt : 1,070,345|1,071,389|1,044|0.1%
cpu : 1,064,067|1,064,066|-1|-0.0%
mu : 7,776,504|7,776,504|0|0.0%
pmu : 8,058,452|8,058,452|0|0.0%
http://www.lionsad.de/xhprof-kit/xhprof/xhprof_html/?run1=5199dd4798f9f&...
=== 8.x..comment-1898054-115 compared (5199dd4798f9f..5199df04dd672):
ct : 143,205|146,004|2,799|2.0%
wt : 1,070,345|1,094,153|23,808|2.2%
cpu : 1,064,067|1,092,069|28,002|2.6%
mu : 7,776,504|7,832,892|56,388|0.7%
pmu : 8,058,452|8,114,632|56,180|0.7%
http://www.lionsad.de/xhprof-kit/xhprof/xhprof_html/?run1=5199dd4798f9f&...
Scenario #2: Using Stark, create a page view of the nodes created in scenario #1 (node with comments). Set site default front page. Again, comparing 8.x (6718550c) to #115.
=== 8.x..8.x compared (5199e3a2bf6f6..5199e51c1ee20):
ct : 223,105|223,105|0|0.0%
wt : 1,653,856|1,653,213|-643|-0.0%
cpu : 1,648,103|1,644,103|-4,000|-0.2%
mu : 10,075,840|10,075,840|0|0.0%
pmu : 10,525,656|10,525,656|0|0.0%
http://www.lionsad.de/xhprof-kit/xhprof/xhprof_html/?run1=5199e3a2bf6f6&...
=== 8.x..comment-1898054-115 compared (5199e3a2bf6f6..5199e5a1880e2):
ct : 223,105|226,808|3,703|1.7%
wt : 1,653,856|1,681,454|27,598|1.7%
cpu : 1,648,103|1,676,104|28,001|1.7%
mu : 10,075,840|10,133,580|57,740|0.6%
pmu : 10,525,656|10,585,052|59,396|0.6%
http://www.lionsad.de/xhprof-kit/xhprof/xhprof_html/?run1=5199e3a2bf6f6&...
Comments
Comment #1
andypostOnce #731724: Convert comment settings into a field to make them work with CMI and non-node entities will be commited then reprofiling will needed
Comment #2
andypostComment #3
star-szrTagging.
Comment #4
andypostComment #5
andypostMostly all related fixed, so need reprofiling
Comment #6
joelpittetThere is nothing really actionable here. Closing for now, feel free to reopen if you know of some possible solutions to make the rendering of comment quicker.
Moving to task and 8.1 as well incase.