Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards
Comment | File | Size | Author |
---|---|---|---|
#8 | 2002332-8-rename-add_table.patch | 9.16 KB | elvis2 |
#3 | 0001-making-add_table-into-camelcase.patch | 9.92 KB | mikedotexe |
Comments
Comment #1
elvis2 CreditAttribution: elvis2 commentedComment #2
mikedotexe CreditAttribution: mikedotexe commentedI'm going to try to jump on this as it's simple and I'm trying to make my first patch.
Comment #3
mikedotexe CreditAttribution: mikedotexe commentedHere's the patch. I put needs review because it's my first patch, but all the functions called are in indeed coming from views, so it looks like it should solve the issue.
Comment #4
oenie CreditAttribution: oenie commentedAdd public access modifier in front of the functions to adher to the new OOP standards.
Comment #6
oenie CreditAttribution: oenie commented#3: 0001-making-add_table-into-camelcase.patch queued for re-testing.
Comment #7
oenie CreditAttribution: oenie commentedLooks good to me now !
Comment #8
elvis2 CreditAttribution: elvis2 commentedRe-rolled patch since access modifier was missing.
Comment #10
elvis2 CreditAttribution: elvis2 commented#8: 2002332-8-rename-add_table.patch queued for re-testing.
Comment #11
oenie CreditAttribution: oenie commentedLooks fine now, really :) !
Comment #12
alexpottCommitted 2c2ae72 and pushed to 8.x. Thanks!