Files: 
CommentFileSizeAuthor
#5 2002338-5-rename-add_tag.patch1.3 KBelvis2
PASSED: [[SimpleTest]]: [MySQL] 55,822 pass(es).
[ View ]
#2 0003-Commit-for-issue-http-drupal.org-node-2002338-to-Ren.patch1.74 KBschiavone
PASSED: [[SimpleTest]]: [MySQL] 57,163 pass(es).
[ View ]

Comments

Assigned:Unassigned» elvis2

StatusFileSize
new1.74 KB
PASSED: [[SimpleTest]]: [MySQL] 57,163 pass(es).
[ View ]

created patch

Assigned:elvis2» Unassigned
Status:Active» Needs review

Status:Needs review» Reviewed & tested by the community

Applied patch successfully. However, based on other issues in #1856630: [Change notice] [META] Rename Views methods to core standards, I think addTag() method needs to made public to abide by new OOP standards.

Status:Reviewed & tested by the community» Needs review
StatusFileSize
new1.3 KB
PASSED: [[SimpleTest]]: [MySQL] 55,822 pass(es).
[ View ]

Rerolled with "public" as the access modifier.

Assigned:Unassigned» elvis2

Status:Needs review» Reviewed & tested by the community

Looks good to me now !

Status:Reviewed & tested by the community» Fixed

Committed 6d41161 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.