Files: 
CommentFileSizeAuthor
#6 views-core-rename-alter-subquery-condition-2002360-06.patch1.65 KBDan Reinders
PASSED: [[SimpleTest]]: [MySQL] 56,086 pass(es).
[ View ]
#2 rename-alter-subquery-condition-2002360-2.patch2.05 KBbrandon_beeler
PASSED: [[SimpleTest]]: [MySQL] 57,353 pass(es).
[ View ]

Comments

Assigned:Unassigned» brandon_beeler

Status:Active» Needs review
StatusFileSize
new2.05 KB
PASSED: [[SimpleTest]]: [MySQL] 57,353 pass(es).
[ View ]

Status:Needs review» Needs work
Issue tags:-Novice, -VDC

The last submitted patch, rename-alter-subquery-condition-2002360-2.patch, failed testing.

Status:Needs work» Needs review
Issue tags:+Novice, +VDC

Status:Needs review» Needs work

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/relationship/GroupwiseMax.phpundefined
@@ -309,7 +309,7 @@ function left_query($options) {
+  function alterSubqueryCondition(AlterableInterface $query, &$conditions) {

Add protected access modifier in front of the function to adhere to the new OOP standards.

Status:Needs work» Needs review
StatusFileSize
new1.65 KB
PASSED: [[SimpleTest]]: [MySQL] 56,086 pass(es).
[ View ]

Added protected access modifier in front of the function to adhere to the new OOP standards.

Status:Needs review» Reviewed & tested by the community

Thank you

Status:Reviewed & tested by the community» Fixed

Committed 93dadb9 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.