Files: 
CommentFileSizeAuthor
#12 views-buildGroupForm-2002378-12.patch1.17 KBEllaTheHarpy
PASSED: [[SimpleTest]]: [MySQL] 55,789 pass(es).
[ View ]
#12 interdiff-9-12.txt1.18 KBEllaTheHarpy
#9 views-buildGroupForm-2002378-9.patch1.55 KBzschmid
FAILED: [[SimpleTest]]: [MySQL] Invalid PHP syntax in core/modules/views/lib/Drupal/views/Plugin/views/filter/FilterPluginBase.php.
[ View ]
#7 views.module-rename_group_build_form_2002378_4.patch767 bytesdrhino
FAILED: [[SimpleTest]]: [MySQL] 55,733 pass(es), 18 fail(s), and 1 exception(s).
[ View ]
#4 views.module-rename_group_build_form-2002378-03.patch1.13 KBtoddtomlinson
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git].
[ View ]
#2 views.module-renamed_build_group_form-2002378-02.patch2.65 KBtoddtomlinson
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git].
[ View ]

Comments

Assigned:Unassigned» toddtomlinson

Assigned:toddtomlinson» Unassigned
Status:Active» Needs review
StatusFileSize
new2.65 KB
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git].
[ View ]

Patch applied that renames build_group_form.

Assigned:Unassigned» toddtomlinson
Status:Needs review» Needs work

Assigned:toddtomlinson» Unassigned
Status:Needs work» Needs review
StatusFileSize
new1.13 KB
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git].
[ View ]

Fixed the patch. Had included previous changes. Only lists build_group_form now.

Status:Needs review» Needs work

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/filter/FilterPluginBase.phpundefined
@@ -829,7 +829,7 @@ public function buildExposedForm(&$form, &$form_state) {
+  function buildGroupForm(&$form, &$form_state) {

Add protected access modifier in front of the function to adher to the new OOP standards.

Assigned:Unassigned» drhino

got it

Status:Needs work» Needs review
StatusFileSize
new767 bytes
FAILED: [[SimpleTest]]: [MySQL] 55,733 pass(es), 18 fail(s), and 1 exception(s).
[ View ]

function is now protected

Status:Needs review» Needs work

You have to make sure there is one patch that contains all changes needed.
Your latest patch is only the latest change.
Try again, including all changes from the original patches.

Assigned:drhino» Unassigned
Status:Needs work» Needs review
StatusFileSize
new1.55 KB
FAILED: [[SimpleTest]]: [MySQL] Invalid PHP syntax in core/modules/views/lib/Drupal/views/Plugin/views/filter/FilterPluginBase.php.
[ View ]

Updated patch

Status:Needs review» Needs work

The last submitted patch, views-buildGroupForm-2002378-9.patch, failed testing.

The issue here is that the buildGroupForm namespace is already used at around line 419 of FilterPluginBase.php .

<?php
 
public function buildGroupForm($form, &$form_state) {
   
$item = &$this->options;
   
// flip. If the filter was a group, set back to a standard filter.
   
$item['is_grouped'] = empty($item['is_grouped']);
   
// If necessary, set new defaults:
   
if ($item['is_grouped']) {
     
$this->build_group_options();
    }
   
$form_state['view']->get('executable')->setItem($form_state['display_id'], $form_state['type'], $form_state['id'], $item);
   
$form_state['view']->addFormToStack($form_state['form_key'], $form_state['display_id'], $form_state['type'], $form_state['id'], TRUE, TRUE);
   
$form_state['view']->cacheSet();
   
$form_state['rerender'] = TRUE;
   
$form_state['rebuild'] = TRUE;
   
$form_state['force_build_group_options'] = TRUE;
  }
?>

renaming the build_group_form method to buildGroupForm throws all sorts of errors. any suggestions on what we should rename this to, to avoid the conflict?

Status:Needs work» Needs review
StatusFileSize
new1.18 KB
new1.17 KB
PASSED: [[SimpleTest]]: [MySQL] 55,789 pass(es).
[ View ]

i read the function and picked a more specific name.

Status:Needs review» Reviewed & tested by the community

Looks wonderful. There are just these two instances.

Title:Rename Views method build_group_form() to buildGroupForm()Change notice: Rename Views method build_group_form() to buildGroupForm()
Project:Drupal core» Views
Version:8.x-dev» 8.x-3.x-dev
Component:views.module» Code
Status:Reviewed & tested by the community» Active
Issue tags:+Needs change record

Committed and pushed to 8.x. Thanks!

Moving to Views for the change notice.

Title:Change notice: Rename Views method build_group_form() to buildGroupForm()Rename Views method build_group_form() to buildGroupForm()
Project:Views» Drupal core
Version:8.x-3.x-dev» 8.x-dev
Component:Code» views.module
Status:Active» Fixed
Issue tags:-Needs change record

Automatically closed -- issue fixed for 2 weeks with no activity.