Files: 
CommentFileSizeAuthor
#6 views-buildGroupOptions-2002380-6.patch1.44 KBzschmid
PASSED: [[SimpleTest]]: [MySQL] 55,863 pass(es).
[ View ]
#1 rename_build_group_options-2002380.patch1.01 KBtheladebug
PASSED: [[SimpleTest]]: [MySQL] 55,737 pass(es).
[ View ]

Comments

Status:Active» Needs review
StatusFileSize
new1.01 KB
PASSED: [[SimpleTest]]: [MySQL] 55,737 pass(es).
[ View ]

Assigned:Unassigned» Nneka

Assigned:Nneka» Unassigned

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/filter/FilterPluginBase.phpundefined
@@ -714,7 +714,7 @@ public function defaultExposeOptions() {
+  function buildGroupOptions() {

Add protected access modifier in front of the function to adher to the new OOP standards.

Status:Needs review» Needs work

Status:Needs work» Needs review
StatusFileSize
new1.44 KB
PASSED: [[SimpleTest]]: [MySQL] 55,863 pass(es).
[ View ]

Updated patch

Status:Needs review» Needs work
Issue tags:-Novice, -VDC

The last submitted patch, views-buildGroupOptions-2002380-6.patch, failed testing.

Status:Needs work» Needs review
Issue tags:+Novice, +VDC

Status:Needs review» Reviewed & tested by the community

Looks fine to me now !

Status:Reviewed & tested by the community» Fixed

Committed c3b21af and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.