Files: 
CommentFileSizeAuthor
#4 drupal_rename_build_group_validate-2002384.patch1.94 KBnathangervais
PASSED: [[SimpleTest]]: [MySQL] 56,019 pass(es).
[ View ]
#2 views.module-renamed-build_group_validate-2002384-02.patch2.62 KBtoddtomlinson
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git].
[ View ]

Comments

Assigned:Unassigned» toddtomlinson

Assigned:toddtomlinson» Unassigned
Status:Active» Needs review
StatusFileSize
new2.62 KB
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git].
[ View ]

Patch attached to rename build_group_validate to buildGroupValidate.

Status:Needs review» Needs work

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/filter/Date.phpundefined
@@ -105,7 +105,7 @@ public function validateValidTime(&$form, $operator, $value) {
+  function buildGroupValidate($form, &$form_state) {
+++ b/core/modules/views/lib/Drupal/views/Plugin/views/filter/FilterPluginBase.phpundefined
@@ -619,7 +619,7 @@ public function validateExposeForm($form, &$form_state) {
+  function buildGroupValidate($form, &$form_state) {
@@ -665,7 +665,7 @@ function build_group_validate($form, &$form_state) {
+  function buildGroupSubmit($form, &$form_state) {

Add protected access modifier in front of the function to adher to the new OOP standards.

Assigned:Unassigned» nathangervais
Status:Needs work» Needs review
StatusFileSize
new1.94 KB
PASSED: [[SimpleTest]]: [MySQL] 56,019 pass(es).
[ View ]

Rerolled patch with protected access modifier for build_group_validate rename to buildGroupValidate()

Status:Needs review» Reviewed & tested by the community

Status:Reviewed & tested by the community» Fixed

Committed 65d70e1 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.