Support from Acquia helps fund testing for Drupal Acquia logo

Comments

toddtomlinson’s picture

Assigned: Unassigned » toddtomlinson
toddtomlinson’s picture

Assigned: toddtomlinson » Unassigned
Status: Active » Needs review
FileSize
2.62 KB

Patch attached to rename build_group_validate to buildGroupValidate.

oenie’s picture

Status: Needs review » Needs work
+++ b/core/modules/views/lib/Drupal/views/Plugin/views/filter/Date.phpundefined
@@ -105,7 +105,7 @@ public function validateValidTime(&$form, $operator, $value) {
+  function buildGroupValidate($form, &$form_state) {

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/filter/FilterPluginBase.phpundefined
@@ -619,7 +619,7 @@ public function validateExposeForm($form, &$form_state) {
+  function buildGroupValidate($form, &$form_state) {

@@ -665,7 +665,7 @@ function build_group_validate($form, &$form_state) {
+  function buildGroupSubmit($form, &$form_state) {

Add protected access modifier in front of the function to adher to the new OOP standards.

nathangervais’s picture

Assigned: Unassigned » nathangervais
Status: Needs work » Needs review
FileSize
1.94 KB

Rerolled patch with protected access modifier for build_group_validate rename to buildGroupValidate()

aspilicious’s picture

Status: Needs review » Reviewed & tested by the community
alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 65d70e1 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.