Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards

CommentFileSizeAuthor
#11 views-rename_build_sort-20088-11.patch4.56 KBJeroenT
#4 views-rename_build_sort-2002388-4.patch5.38 KBJeroenT
#2 views.core-rename_build_sort-2002388-02.patch6.18 KBtoddtomlinson
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

toddtomlinson’s picture

toddtomlinson CreditAttribution: toddtomlinson commented
Assigned: Unassigned » toddtomlinson
toddtomlinson’s picture

toddtomlinson CreditAttribution: toddtomlinson commented
Assigned: toddtomlinson » Unassigned
Status: Active » Needs review
FileSize
views.core-rename_build_sort-2002388-02.patch6.18 KB

Patch renames build_sort to buildSort.

oenie’s picture

oenie CreditAttribution: oenie commented
Status: Needs review » Needs work 
+++ b/core/modules/views/lib/Drupal/views/Plugin/views/style/StylePluginBase.phpundefined
@@ -373,7 +373,7 @@ function wizard_submit(&$form, &$form_state, WizardInterface $wizard, &$display_
+  function buildSort() { return TRUE; }

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/style/Table.phpundefined
@@ -103,7 +103,7 @@ protected function defineOptions() {
+  function buildSort() {

Add public access modifier in front of the functions to adher to the new OOP standards.

JeroenT’s picture

JeroenT
Primary language Dutch
Location 🇧🇪
CreditAttribution: JeroenT commented
Status: Needs work » Needs review
FileSize
views-rename_build_sort-2002388-4.patch5.38 KB
oenie’s picture

oenie CreditAttribution: oenie commented

Looks fine to me now ! Once the patch passed testbot, it's RTBC for me.

Status: Needs review » Needs work
Issue tags: -Novice, -VDC

The last submitted patch, views-rename_build_sort-2002388-4.patch, failed testing.

JeroenT’s picture

JeroenT
Primary language Dutch
Location 🇧🇪
CreditAttribution: JeroenT commented
Status: Needs work » Needs review
Issue tags: +Novice, +VDC

#4: views-rename_build_sort-2002388-4.patch queued for re-testing.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented

So we rename vars and functions at the same time?

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
Status: Needs review » Needs work

No that is out of scope :)

somepal’s picture

somepal CreditAttribution: somepal commented

except variables are renamed too!

JeroenT’s picture

JeroenT
Primary language Dutch
Location 🇧🇪
CreditAttribution: JeroenT commented
Status: Needs work » Needs review
FileSize
views-rename_build_sort-20088-11.patch4.56 KB

Only renamed the build_sort function.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs review » Reviewed & tested by the community

Thank you. Code looks fine, there is no other call and patch applies.

Status: Reviewed & tested by the community » Needs work
Issue tags: -Novice, -VDC

The last submitted patch, views-rename_build_sort-20088-11.patch, failed testing.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Needs work » Needs review
Issue tags: +Novice, +VDC

#11: views-rename_build_sort-20088-11.patch queued for re-testing.

dcam’s picture

dcam CreditAttribution: dcam commented
Status: Needs review » Reviewed & tested by the community

#11 still applies and was already RTBC in #12.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed e41c6e1 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.