Files: 
CommentFileSizeAuthor
#10 2002394-10.patch1.04 KBjibran
PASSED: [[SimpleTest]]: [MySQL] 56,958 pass(es).
[ View ]
#7 views-rename_build_sorts-2002394-7.patch1.04 KBbroeker
PASSED: [[SimpleTest]]: [MySQL] 55,789 pass(es).
[ View ]
#6 views-rename_build_sorts-2002394-6.patch1.04 KBbroeker
PASSED: [[SimpleTest]]: [MySQL] 55,720 pass(es).
[ View ]
#3 rename_op_longer-2003566-2.patch1.02 KBbroeker
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git].
[ View ]
#2 rename_build_sorts-2002394-1.patch1.04 KBbroeker
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git].
[ View ]

Comments

Assigned:Unassigned» broeker

Working on it

StatusFileSize
new1.04 KB
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git].
[ View ]

StatusFileSize
new1.02 KB
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git].
[ View ]

Ignore this one, wrong patch!

Status:Active» Needs review

Oops, ignore comment #3 I was working on two issues and uploaded the wrong patch here.

Status:Needs review» Needs work

The last submitted patch, rename_op_longer-2003566-2.patch, failed testing.

StatusFileSize
new1.04 KB
PASSED: [[SimpleTest]]: [MySQL] 55,720 pass(es).
[ View ]

Another attempt...

Status:Needs work» Needs review
StatusFileSize
new1.04 KB
PASSED: [[SimpleTest]]: [MySQL] 55,789 pass(es).
[ View ]

Setting to needs review for testbot

Status:Needs review» Reviewed & tested by the community

Looks good to me now !

Status:Reviewed & tested by the community» Needs work

Needs a re-roll

curl http://drupal.org/files/views-rename_build_sorts-2002394-7.patch |  git a
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  1062  100  1062    0     0   3028      0 --:--:-- --:--:-- --:--:--  6138
error: patch failed: core/modules/views/lib/Drupal/views/Plugin/views/wizard/WizardPluginBase.php:207
error: core/modules/views/lib/Drupal/views/Plugin/views/wizard/WizardPluginBase.php: patch does not apply

Status:Needs work» Needs review
StatusFileSize
new1.04 KB
PASSED: [[SimpleTest]]: [MySQL] 56,958 pass(es).
[ View ]

re-roll
conflict

++<<<<<<< HEAD
+    $this->buildFilters($form, $form_state);
+    $this->build_sorts($form, $form_state);
++=======
+     $this->build_filters($form, $form_state);
+     $this->buildSorts($form, $form_state);
++>>>>>>> 7

resolved
-    $this->build_filters($form, $form_state);
+    $this->buildFilters($form, $form_state);
-     $this->build_sorts($form, $form_state);
+     $this->buildSorts($form, $form_state);

Status:Needs review» Reviewed & tested by the community

Looks good to me now !

Status:Reviewed & tested by the community» Fixed

Committed 18fad64 and pushed to 8.x. Thanks!

Committed 18fad64 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.