Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards

CommentFileSizeAuthor
#14 7449722-rename-method-cache-get-11.patch2.24 KBfmizzell
#9 7449722-rename-method-cache-get-9.patch2.23 KBfmizzell
#4 7449722-rename-method-cache-get-4.patch2.23 KBfmizzell
#2 7449722-rename-method-cache-get.patch2.22 KBfmizzell
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

fmizzell’s picture

fmizzell CreditAttribution: fmizzell commented
Assigned: Unassigned » fmizzell
fmizzell’s picture

fmizzell CreditAttribution: fmizzell commented
Status: Active » Needs review
FileSize
7449722-rename-method-cache-get.patch2.22 KB
oenie’s picture

oenie CreditAttribution: oenie commented
Status: Needs review » Needs work 
+++ b/core/modules/views/lib/Drupal/views/Plugin/views/cache/CachePluginBase.phpundefined
@@ -141,7 +141,7 @@ function cache_set($type) {
+  function cacheGet($type) {

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/cache/None.phpundefined
@@ -31,11 +31,11 @@ public function summaryTitle() {
+  function cacheGet($type) {

Add public access modifier in front of the functions to adher to the new OOP standards.

fmizzell’s picture

fmizzell CreditAttribution: fmizzell commented
Status: Needs work » Needs review
FileSize
7449722-rename-method-cache-get-4.patch2.23 KB

Status: Needs review » Needs work

The last submitted patch, 7449722-rename-method-cache-get-4.patch, failed testing.

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn commented

Failing tests. Please test and re-roll.

oenie’s picture

oenie CreditAttribution: oenie commented
Status: Needs work » Needs review

#4: 7449722-rename-method-cache-get-4.patch queued for re-testing.

oenie’s picture

oenie CreditAttribution: oenie commented
Status: Needs review » Needs work

I really hate to do this ... but unfortunately we need a reroll, the patch doesn't apply anymore.

fmizzell’s picture

fmizzell CreditAttribution: fmizzell commented
Status: Needs work » Needs review
FileSize
7449722-rename-method-cache-get-9.patch2.23 KB
aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
Status: Needs review » Reviewed & tested by the community
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Issue tags: -Novice, -VDC

#9: 7449722-rename-method-cache-get-9.patch queued for re-testing.

Status: Reviewed & tested by the community » Needs work
Issue tags: +Novice, +VDC

The last submitted patch, 7449722-rename-method-cache-get-9.patch, failed testing.

oenie’s picture

oenie CreditAttribution: oenie commented
Issue tags: +Needs reroll

Unfortunately we need a reroll, the patch doesn't apply anymore.

fmizzell’s picture

fmizzell CreditAttribution: fmizzell commented
Status: Needs work » Needs review
Issue tags: -Needs reroll
FileSize
7449722-rename-method-cache-get-11.patch2.24 KB
aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
Status: Needs review » Reviewed & tested by the community
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed fc827a8 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.