Files: 
CommentFileSizeAuthor
#23 views-rename_can_build_group-2002416-23.patch1.32 KBJeroenT
PASSED: [[SimpleTest]]: [MySQL] 56,306 pass(es).
[ View ]
#19 2002416-rename-can_build_group.patch1.32 KBsillygwailo
FAILED: [[SimpleTest]]: [MySQL] 57,410 pass(es), 71 fail(s), and 42 exception(s).
[ View ]
#17 rename-can_build_group-views-2002416-17.patch1.31 KBmari3.14
PASSED: [[SimpleTest]]: [MySQL] 56,927 pass(es).
[ View ]
#15 2002416-rename-can_build_group.patch1.32 KBsillygwailo
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 2002416-rename-can_build_group_1.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
#14 2002416-14.patch0 bytesjibran
FAILED: [[SimpleTest]]: [MySQL] 56,009 pass(es), 1 fail(s), and 0 exception(s).
[ View ]
#11 rename-can_build_group-views-2002416-11.patch1.32 KBmari3.14
PASSED: [[SimpleTest]]: [MySQL] 57,127 pass(es).
[ View ]
#8 views-rename_can_build_group-2002416-8.patch1.31 KBJeroenT
FAILED: [[SimpleTest]]: [MySQL] 57,837 pass(es), 1 fail(s), and 0 exception(s).
[ View ]
#6 2002416-rename-can_build_group.patch1.32 KBsillygwailo
FAILED: [[SimpleTest]]: [MySQL] 55,808 pass(es), 72 fail(s), and 42 exception(s).
[ View ]
#3 2002416-rename-can_build_group.patch1.31 KBsillygwailo
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git].
[ View ]

Comments

Taking this with baldwinlouie.

Status:Active» Needs review
StatusFileSize
new1.31 KB
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git].
[ View ]

Patch attached, no testing done, method only appears in one place.

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/filter/FilterPluginBase.phpundefined
@@ -175,7 +175,7 @@ public function canExpose() { return TRUE; }
+  function canBuildGroup() {

This should be marked as protected

These are the only places the method is used.

Status:Needs review» Needs work

The last submitted patch, 2002416-rename-can_build_group.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new1.32 KB
FAILED: [[SimpleTest]]: [MySQL] 55,808 pass(es), 72 fail(s), and 42 exception(s).
[ View ]

Re-rolled as protected.

Status:Needs review» Needs work

The last submitted patch, 2002416-rename-can_build_group.patch, failed testing.

StatusFileSize
new1.31 KB
FAILED: [[SimpleTest]]: [MySQL] 57,837 pass(es), 1 fail(s), and 0 exception(s).
[ View ]

rename can_build_group to canBuildGroup.

Status:Needs work» Needs review

marking as needs review.

Status:Needs review» Needs work

The last submitted patch, views-rename_can_build_group-2002416-8.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new1.32 KB
PASSED: [[SimpleTest]]: [MySQL] 57,127 pass(es).
[ View ]

Patch re-rolled, tested locally, let's see if I am lucky

Status:Needs review» Reviewed & tested by the community

Looks good to me now !

Status:Reviewed & tested by the community» Needs work

Needs a re-roll

curl http://drupal.org/files/rename-can_build_group-views-2002416-11.patch | git a
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  1348  100  1348    0     0    481      0  0:00:02  0:00:02 --:--:--   513
error: patch failed: core/modules/views/lib/Drupal/views/Plugin/views/filter/FilterPluginBase.php:175
error: core/modules/views/lib/Drupal/views/Plugin/views/filter/FilterPluginBase.php: patch does not apply

Status:Needs work» Needs review
StatusFileSize
new0 bytes
FAILED: [[SimpleTest]]: [MySQL] 56,009 pass(es), 1 fail(s), and 0 exception(s).
[ View ]

Reroll
Conflict

++<<<<<<< HEAD
+  function can_build_group() {
+    return $this->isExposed() && (count($this->operatorOptions()) > 0);
++=======
+   protected function canBuildGroup() {
+     return $this->isExposed() && (count($this->operator_options()) > 0);
++>>>>>>> 11

Resloved
-   function can_build_group() {
-  protected function canBuildGroup() {
-    return $this->isExposed() && (count($this->operator_options()) > 0);
++  function canBuildGroup() {
+    return $this->isExposed() && (count($this->operatorOptions()) > 0);

StatusFileSize
new1.32 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 2002416-rename-can_build_group_1.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Empty patch? Re-rolled.

Status:Needs review» Needs work

The last submitted patch, 2002416-rename-can_build_group.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new1.31 KB
PASSED: [[SimpleTest]]: [MySQL] 56,927 pass(es).
[ View ]

Re-rolling the patch following suggestions

[I am learning about patching but I do not think this is going to be the one; I am happy to try again if someone tells me what needs changing please]

Status:Needs review» Needs work

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/filter/FilterPluginBase.phpundefined
@@ -175,7 +175,7 @@ public function canExpose() { return TRUE; }
+  function canBuildGroup() {

Should be a protected method.

StatusFileSize
new1.32 KB
FAILED: [[SimpleTest]]: [MySQL] 57,410 pass(es), 71 fail(s), and 42 exception(s).
[ View ]

Re-rolled with protected.

Status:Needs work» Needs review

Status:Needs review» Needs work

The last submitted patch, 2002416-rename-can_build_group.patch, failed testing.

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/filter/FilterPluginBase.phpundefined
@@ -197,14 +197,14 @@ public function buildOptionsForm(&$form, &$form_state) {
-    if ($this->can_build_group()) {
+    if ($this->canBuildBroup()) {

You made a typo here: Should be canBuildGroup instead

Status:Needs work» Needs review
StatusFileSize
new1.32 KB
PASSED: [[SimpleTest]]: [MySQL] 56,306 pass(es).
[ View ]

Renamed can_build_group to canBuildGroup. Added protected access modifier as mentioned by dawehner.

Status:Needs review» Reviewed & tested by the community

Seems fine.

Status:Reviewed & tested by the community» Fixed

Committed 7d31103 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.