Files: 
CommentFileSizeAuthor
#3 2002420-check_access-2.patch3.32 KBoenie
PASSED: [[SimpleTest]]: [MySQL] 55,889 pass(es).
[ View ]
#2 2002420-check_access-1.patch3.3 KBoenie
PASSED: [[SimpleTest]]: [MySQL] 55,681 pass(es).
[ View ]

Comments

Assigned:Unassigned» oenie

Status:Active» Needs review
StatusFileSize
new3.3 KB
PASSED: [[SimpleTest]]: [MySQL] 55,681 pass(es).
[ View ]

This tag covers two separate check_access functions

- 1 in views/lib/Drupal/views/Plugin/views/argument_validator/ArgumentValidatorPluginBase.php
- 1 in views/lib/Drupal/views/Plugin/views/argument_default/ArgumentDefaultPluginBase.php

StatusFileSize
new3.32 KB
PASSED: [[SimpleTest]]: [MySQL] 55,889 pass(es).
[ View ]

Same patch, but added the forgotten access modifier for both functions.

Status:Needs review» Needs work
Issue tags:-Novice, -VDC

The last submitted patch, 2002420-check_access-2.patch, failed testing.

Status:Needs work» Needs review
Issue tags:+Novice, +VDC

#3: 2002420-check_access-2.patch queued for re-testing.

Status:Needs review» Reviewed & tested by the community

Looks good to me now !

Status:Reviewed & tested by the community» Needs review

@oenie it's a point of process not to rtbc your own patches.

@alexxpott: a bit too eager, hadn't even noticed that !
sorry :)

#3: 2002420-check_access-2.patch queued for re-testing.

Status:Needs review» Reviewed & tested by the community

I can do that :)

Status:Reviewed & tested by the community» Fixed

Committed fb03231 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.