Files: 
CommentFileSizeAuthor
#7 rename-views-method-click-sort-2002424-7.patch1.85 KBweb.dev.cas
PASSED: [[SimpleTest]]: [MySQL] 55,895 pass(es).
[ View ]
#6 rename-views-method-click-sort-2002424-6.patch1.85 KBweb.dev.cas
Test request sent.
[ View ]
#4 2002424-rename-views-method-part2.patch1.84 KBweb.dev.cas
PASSED: [[SimpleTest]]: [MySQL] 55,731 pass(es).
[ View ]
#2 2002424-rename-views-method.patch1.24 KBweb.dev.cas
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git].
[ View ]

Comments

Assigned:Unassigned» web.dev.cas

Working on this as part of core code sprint.

StatusFileSize
new1.24 KB
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git].
[ View ]

Replaced two instances of click_sort() with clickSort().

Status:Active» Needs review

Forgot to set status to needs review.

StatusFileSize
new1.84 KB
PASSED: [[SimpleTest]]: [MySQL] 55,731 pass(es).
[ View ]

I missed an instance of click_sort(). Attaching new complete patch.

Status:Needs review» Needs work

+++ b/core/modules/field/lib/Drupal/field/Plugin/views/field/Field.phpundefined
@@ -240,7 +240,7 @@ function click_sortable() {
+  function clickSort($order) {
+++ b/core/modules/views/lib/Drupal/views/Plugin/views/field/FieldPluginBase.phpundefined
@@ -165,7 +165,7 @@ function add_additional_fields($fields = NULL) {
+  function clickSort($order) {

Add public access modifier in front of the functions to adher to the new OOP standards.

Status:Needs work» Needs review
StatusFileSize
new1.85 KB
Test request sent.
[ View ]

Added public access modifier to clickSort functions. Thanks, oenie!

StatusFileSize
new1.85 KB
PASSED: [[SimpleTest]]: [MySQL] 55,895 pass(es).
[ View ]

The status of the last patch was stuck in "Test request sent" comment display, but on inspecting details, I saw that it in fact failed system test. Resubmitting new version of patch based upon latest repo pull.

Status:Needs review» Needs work
Issue tags:-Novice, -VDC

The last submitted patch, rename-views-method-click-sort-2002424-7.patch, failed testing.

Status:Needs work» Needs review
Issue tags:+Novice, +VDC

The re-test of patch #7 passed. This issue needs community review.

Status:Needs review» Reviewed & tested by the community

Looks good.

Status:Reviewed & tested by the community» Fixed

Committed 51d364e and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.