Files: 
CommentFileSizeAuthor
#4 views_rename_compile_fields-2002428-4.patch884 bytesnathangervais
PASSED: [[SimpleTest]]: [MySQL] 55,863 pass(es).
[ View ]
#2 views-rename-compile_fields-2002428-2.patch866 byteshansenm
FAILED: [[SimpleTest]]: [MySQL] 55,887 pass(es), 1 fail(s), and 0 exception(s).
[ View ]

Comments

Assigned:Unassigned» hansenm

I'll take this one.

Status:Active» Needs review
StatusFileSize
new866 bytes
FAILED: [[SimpleTest]]: [MySQL] 55,887 pass(es), 1 fail(s), and 0 exception(s).
[ View ]

Submitting a patch to update the compile_fields method.

Status:Needs review» Needs work

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/query/Sql.phpundefined
@@ -1189,7 +1189,7 @@ function get_non_aggregates() {
+  function compileFields($query) {

Add protected access modifier in front of the functions to adher to the new OOP standards.

Assigned:hansenm» nathangervais
Status:Needs work» Needs review
StatusFileSize
new884 bytes
PASSED: [[SimpleTest]]: [MySQL] 55,863 pass(es).
[ View ]

Rerolled Patch with Protected Access modifier

Status:Needs review» Reviewed & tested by the community

Perfect

Title:Rename Views method compile_fields() to compileFields()Change notice: Rename Views method compile_fields() to compileFields()
Project:Drupal core» Views
Version:8.x-dev» 8.x-3.x-dev
Component:views.module» Code
Status:Reviewed & tested by the community» Active
Issue tags:+Needs change record

Committed and pushed to 8.x. Thanks!

Moving to Views for the change notice.

Title:Change notice: Rename Views method compile_fields() to compileFields()Rename Views method compile_fields() to compileFields()
Project:Views» Drupal core
Version:8.x-3.x-dev» 8.x-dev
Component:Code» views.module
Assigned:nathangervais» Unassigned
Status:Active» Fixed
Issue tags:-Needs change record

Automatically closed -- issue fixed for 2 weeks with no activity.