Files: 
CommentFileSizeAuthor
#3 rename-condition-namespace-2002430-1.patch1.66 KBhugo.lallo
PASSED: [[SimpleTest]]: [MySQL] 55,689 pass(es).
[ View ]
#1 rename-condition-namespace-2002430.patch1.65 KBhugo.lallo
PASSED: [[SimpleTest]]: [MySQL] 55,705 pass(es).
[ View ]

Comments

Status:Active» Needs review
StatusFileSize
new1.65 KB
PASSED: [[SimpleTest]]: [MySQL] 55,705 pass(es).
[ View ]

Status:Needs review» Needs work

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/relationship/GroupwiseMax.phpundefined
@@ -329,7 +329,7 @@ function alter_subquery_condition(AlterableInterface $query, &$conditions) {
+  function conditionNamespace($string) {

Add protected access modifier in front of the functions to adher to the new OOP standards.

StatusFileSize
new1.66 KB
PASSED: [[SimpleTest]]: [MySQL] 55,689 pass(es).
[ View ]

Status:Needs work» Needs review

Status:Needs review» Reviewed & tested by the community

Looks fine by me !

Status:Reviewed & tested by the community» Fixed

Committed 875ee5c and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.