Files: 
CommentFileSizeAuthor
#4 2002432-rename-convert_exposed_input.patch1.6 KBsillygwailo
PASSED: [[SimpleTest]]: [MySQL] 55,722 pass(es).
[ View ]
#2 2002432-rename-convert_exposed_imput.patch1.59 KBsillygwailo
FAILED: [[SimpleTest]]: [MySQL] 56,534 pass(es), 1 fail(s), and 0 exception(s).
[ View ]

Comments

Assigned:Unassigned» sillygwailo

Taking this one with baldwinlouie.

Status:Active» Needs review
StatusFileSize
new1.59 KB
FAILED: [[SimpleTest]]: [MySQL] 56,534 pass(es), 1 fail(s), and 0 exception(s).
[ View ]

Patch attached.

Status:Needs review» Needs work

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/filter/FilterPluginBase.phpundefined
@@ -1213,7 +1213,7 @@ public function exposedInfo() {
+  function convertExposedInput(&$input, $selected_group_id = NULL) {

Add public access modifier in front of the functions to adher to the new OOP standards.

Status:Needs work» Needs review
StatusFileSize
new1.6 KB
PASSED: [[SimpleTest]]: [MySQL] 55,722 pass(es).
[ View ]

Re-rolling with public access modifier.

Status:Needs review» Needs work
Issue tags:-Novice, -VDC

The last submitted patch, 2002432-rename-convert_exposed_input.patch, failed testing.

Status:Needs work» Needs review
Issue tags:+Novice, +VDC

Status:Needs review» Reviewed & tested by the community

Looks good to me now !

Status:Reviewed & tested by the community» Fixed

Committed 6295bdf and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.