Files: 
CommentFileSizeAuthor
#7 interdiff.txt3.24 KBheddn
#6 element_label_type-rename-2002474-6.patch3.14 KBheddn
PASSED: [[SimpleTest]]: [MySQL] 55,816 pass(es).
[ View ]
#6 interdiff.txt3.24 KBheddn
#2 element_label_type-rename-2002474.patch2.01 KBbrennanmh
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch element_label_type-rename-2002474.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Comments

Assigned:Unassigned» lieb

Assigned to myself - working on now.

Assigned:lieb» Unassigned
Status:Active» Needs review
StatusFileSize
new2.01 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch element_label_type-rename-2002474.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

# modified: core/modules/views/lib/Drupal/views/Plugin/views/field/FieldPluginBase.php
# modified: core/modules/views/views.theme.inc
#

Oops, sorry. It was unassigned when I started.

Status:Needs review» Needs work

The last submitted patch, element_label_type-rename-2002474.patch, failed testing.

Assigned:Unassigned» brennanmh

Took ownership.

StatusFileSize
new3.24 KB
new3.14 KB
PASSED: [[SimpleTest]]: [MySQL] 55,816 pass(es).
[ View ]

No longer applies. Re-rolled.

Status:Needs work» Needs review
StatusFileSize
new3.24 KB

interdiff is backwards in #6. Here's a corrected diff.

The changed in #6 adds public to elementLabelType() and fixed a couple places where calls to elementLabelType() weren't renamed.

Status:Needs review» Reviewed & tested by the community

Looking good

Status:Reviewed & tested by the community» Fixed

Committed 4c40f82 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.