Files: 
CommentFileSizeAuthor
#5 rename-view-method-2002478-5.patch1.38 KBarielqgold
PASSED: [[SimpleTest]]: [MySQL] 56,029 pass(es).
[ View ]
#3 rename-view-method-2002478-3.patch1.37 KBarielqgold
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git].
[ View ]
#2 rename-view-method-2002478-2.patch636 bytesarielqgold
FAILED: [[SimpleTest]]: [MySQL] 55,513 pass(es), 86 fail(s), and 22 exception(s).
[ View ]

Comments

Assigned:Unassigned» arielqgold

Status:Active» Needs review
StatusFileSize
new636 bytes
FAILED: [[SimpleTest]]: [MySQL] 55,513 pass(es), 86 fail(s), and 22 exception(s).
[ View ]

Patch attached.

StatusFileSize
new1.37 KB
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git].
[ View ]

Rerolled patch.

Status:Needs review» Needs work

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/field/FieldPluginBase.phpundefined
@@ -349,7 +349,7 @@ function element_label_classes($row_index = NULL) {
+  function elementWrapperClasses($row_index = NULL) {

Add public access modifier in front of the function to adher to the new OOP standards.

Status:Needs work» Needs review
StatusFileSize
new1.38 KB
PASSED: [[SimpleTest]]: [MySQL] 56,029 pass(es).
[ View ]

Rerolled patch.

Are the new OOP coding standards documented?

I now see that comment #28 in https://drupal.org/node/1856630 suggests that public is a good default.

It kind of depends on how the function is used.
If it's a function that's only used from a class instance itself ($this->elementWrapperClasses), you could set it to protected.
But public usually is a safe bet.

Status:Needs review» Reviewed & tested by the community

Looks fine now.

Status:Reviewed & tested by the community» Fixed

Committed/pushed to 8.x, thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.