Files: 
CommentFileSizeAuthor
#4 views-elementWrapperType-2002480-4.patch1.5 KBJeroenT
PASSED: [[SimpleTest]]: [MySQL] 57,345 pass(es).
[ View ]
#2 rename-elementwrappertype-function-2002480-2.patch1.49 KBilleace
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git].
[ View ]

Comments

Working on this at drupalcon code sprints.

Status:Active» Needs review
StatusFileSize
new1.49 KB
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git].
[ View ]

Status:Needs review» Needs work

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/field/FieldPluginBase.phpundefined
@@ -246,7 +246,7 @@ function element_label_type($none_supported = FALSE, $default_empty = FALSE) {
+  function elementWrapperType($none_supported = FALSE, $default_empty = FALSE) {

Add public access modifier in front of the function to adher to the new OOP standards.

Status:Needs work» Needs review
StatusFileSize
new1.5 KB
PASSED: [[SimpleTest]]: [MySQL] 57,345 pass(es).
[ View ]

added public to elementWrapperType function

Status:Needs review» Reviewed & tested by the community

Looks good to me now !

Status:Reviewed & tested by the community» Fixed

Committed 960eb82 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.