Files: 
CommentFileSizeAuthor
#6 drupal-camelcase-replace.2002496.6.patch3.05 KBbaldwinlouie
PASSED: [[SimpleTest]]: [MySQL] 55,940 pass(es).
[ View ]
#3 drupal-camelcase-replace-2002496.3.patch3.46 KBbaldwinlouie
FAILED: [[SimpleTest]]: [MySQL] 55,690 pass(es), 1 fail(s), and 1 exception(s).
[ View ]
#2 drupal-camelcase-replace-2002496-7450426.patch3.46 KBbaldwinlouie
PASSED: [[SimpleTest]]: [MySQL] 55,785 pass(es).
[ View ]

Comments

Assigned:Unassigned» baldwinlouie

taking by baldwinlouie and sillygwilo

Status:Active» Needs review
StatusFileSize
new3.46 KB
PASSED: [[SimpleTest]]: [MySQL] 55,785 pass(es).
[ View ]

attaching patch

StatusFileSize
new3.46 KB
FAILED: [[SimpleTest]]: [MySQL] 55,690 pass(es), 1 fail(s), and 1 exception(s).
[ View ]

rerolling with access modifier

Status:Needs review» Needs work

The last submitted patch, drupal-camelcase-replace-2002496.3.patch, failed testing.

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/pager/PagerPluginBase.phpundefined
@@ -239,7 +239,7 @@ function has_more_records() {
+  function exposedFormAlter(&$form, &$form_state) { }
+++ b/core/modules/views/lib/Drupal/views/Plugin/views/pager/SqlBase.phpundefined
@@ -335,7 +335,7 @@ function offset_exposed() {
+  function exposedFormAlter(&$form, &$form_state) {

Still missing some public access modifiers.

+++ b/core/modules/views/views.moduleundefined
@@ -1489,7 +1489,7 @@ function views_exposed_form($form, &$form_state) {
-function views_form_views_exposed_form_alter(&$form, &$form_state) {
+function views_form_views_exposedFormAlter(&$form, &$form_state) {

This is an incorrect replacement. You are changing the name of a hook, which subsequently will never be called anymore. Should stay as is. (although the hook-system is on it's way out if i'm not mistaken)

Status:Needs work» Needs review
StatusFileSize
new3.05 KB
PASSED: [[SimpleTest]]: [MySQL] 55,940 pass(es).
[ View ]

Rerolled with correct modifiers.

Status:Needs review» Reviewed & tested by the community

No calls left, and patch still applies.

Status:Reviewed & tested by the community» Fixed

Committed c481e2f and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.