Files: 
CommentFileSizeAuthor
#7 drupal-views_rename_exposed_translate_method-2002502-7.patch1.39 KBarh1
PASSED: [[SimpleTest]]: [MySQL] 55,702 pass(es).
[ View ]
#2 drupal-views_rename_exposed_translate_method-2002502-2.patch1.38 KBarh1
PASSED: [[SimpleTest]]: [MySQL] 55,871 pass(es).
[ View ]

Comments

Assigned:Unassigned» arh1

Sprinting: I'll work on this!

Status:Active» Needs review
StatusFileSize
new1.38 KB
PASSED: [[SimpleTest]]: [MySQL] 55,871 pass(es).
[ View ]

Patch attached.

Status:Needs review» Needs work
Issue tags:-Novice, -VDC

The last submitted patch, drupal-views_rename_exposed_translate_method-2002502-2.patch, failed testing.

Status:Needs work» Needs review
Issue tags:+Novice, +VDC

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/filter/FilterPluginBase.phpundefined
@@ -1106,7 +1106,7 @@ public function addGroupForm($form, &$form_state) {
+  function exposedTranslate(&$form, $type) {

Add protected access modifier in front of the function to adher to the new OOP standards.

Status:Needs review» Needs work

Status:Needs work» Needs review
StatusFileSize
new1.39 KB
PASSED: [[SimpleTest]]: [MySQL] 55,702 pass(es).
[ View ]

Thanks, oenie. Rerolled with the protected access modifier.

Status:Needs review» Reviewed & tested by the community

Looks fine to me now !

Status:Reviewed & tested by the community» Fixed

Committed c7d2aab and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.