Problem/Motivation

Proposed resolution

Remove the lines of code that declare the unused variables.

Is there a way to automatically detect? No. See #12-#14.

Remaining tasks

  • (done) Identify each file that has an unused variable.
  • (done) Make one issue per file.
  • Also, write down reproducable steps to identifying per file, each unused variable. Might require IDE.
  • (done) Create the issue and list the variables in that issue.
  • (done) Add the file to the table.
  • (done) Link the issue in the table.
  • Do a few that are active or needs work.
  • Review a few. See hints for reviewers.

Hints

Be careful of an include_once. It might use the variables that an IDE says is unused, but it is actually used. There are very few places in core that do that, but be careful of it.

(Small note be careful of list(). Most people can ignore this.)

Hints for reviewers

  1. Look at the patch with dreditor (http://dreditor.org).
  2. Apply the patch, then
    • If it does not apply:
      • If you have time, reroll it. (reroll instructions: http://drupal.org/patch/reroll) Interdiffs usually do not make sense with rerolls, but you can add some info like saying if it was an automatic merge, if there were conflicts, and if you found the issue/commit that caused it to not apply, mention that. If you do not have time to reroll it, mark the status needs work, and add the Needs reroll tag.
      • If the patch cannot be applied because it was already fixed by other patch (the line/lines to fix dissapeared), find the issue where that patch was posted and reference it. Then, you can mark it as "Closed (won't fix)" . Example: #2080539: Remove Unused local variable $langcode from /core/modules/forum/lib/Drupal/forum/Tests/ForumBlockTest.php
    • If it did apply, recheck (by opening the file in an IDE like phpstorm) if any new unused variables are revealed by the removal of other unused variables.
  3. Look at the code near the var. If you think the unused var.. actually needed to be used, you may have spotted a flaw that needs to be fixed. (For example: #2002708-7: Remove unused local variables from core/includes/common.inc and #2067551-5: /core/lib/Drupal/Core/Routing/MatcherDumper.php will never roll back its transaction.)
  4. Summarize what you checked, how you checked them, and your findings (instead of just saying "looks good"). For example #2080367-2: Remove Unused local variable $storageFactory from core/tests/Drupal/Tests/Component/PhpStorage/MTimeProtectedFileStorageTest.php.
  5. Also see https://drupal.org/contributor-tasks/review for more info.

table of issues

File Issue
core/modules/system/lib/Drupal/system/SystemConfigSubscriber.php #2056445: Ensure that all config can not be deleted using the config importer Assigned to: rahul.shinde
core/modules/node/lib/Drupal/node/Tests/NodeSaveTest.php #2064639: Remove unused local variables from the node module
core/includes/menu.inc #2002726: Remove unused local variables from core/includes/menu.inc
core/modules/php/lib/Drupal/php/Plugin/Filter/Php.php #2061397: Remove unused local variables from the Views UI module
/core/modules/views/lib/Drupal/views/Plugin/views/field/FieldPluginBase.php #2072597: Remove Unused local variables from the Views module Assigned to: jgSnell
/core/lib/Drupal/Component/Diff/DiffEngine.php #2079863: Remove Unused local variable from /core/lib/Drupal/Component/Diff/DiffEngine.php
/core/modules/system/lib/Drupal/system/Tests/Database/SelectTest.php #2080311: Clean up Drupal\system\Tests\Database\SelectTest.php
/core/modules/system/lib/Drupal/system/Tests : Ajax/ElementValidationTest.php, Database/DatabaseTestBase.php, Database/SelectOrderedTest.php, Form/ProgrammaticTest.php, Lock/LockFunctionalTest.php, System/FrontPageTest.php #2080343: Remove Unused local variables from system module Assigned to: lokapujya
/core/modules/language/language.negotiation.inc #2080427: Remove Unused local variables from language module
/core/modules/search/search.api.php #2080547: Remove Unused local variables from search module.
/core/modules/translation/lib/Drupal/translation/Tests/TranslationTest.php #2080559: Remove unused local variables from the translation module
/core/includes/bootstrap.inc #2081137: Remove unused local variables from /core/includes/bootstrap.inc
/core/tests/* : Drupal/Tests/Core/Asset/CssCollectionRendererUnitTest.php, Drupal/Tests/Core/Routing/MimeTypeMatcherTest.php, Drupal/Tests/Core/Plugin/Discovery/DerivativeDiscoveryDecoratorTest.php, Drupal/Tests/Component/Datetime/DateTimePlusTest.php #2081153: Remove unused local variables from core/tests

Completed issues

/core/lib/Drupal/Core/Entity/DatabaseStorageController.php
/core/lib/Drupal/Core/Entity/DatabaseStorageControllerNG.php
/core/lib/Drupal/Core/Entity/EntityNG.php
File Issue
/core/modules/datetime/lib/Drupal/datetime/Plugin/field/widget/DatetimeDatelistWidget.php #2081163: Remove unused local variables from the datetime module
/core/modules/link/lib/Drupal/link/Plugin/field/field_type/LinkItem.php #2081169: Remove unused local variables from the link module
/core/modules/ckeditor/lib/Drupal/ckeditor/Tests/CKEditorLoadingTest.php #2081173: Remove unused local variables from the CKEditor module Assigned to: guregori
/core/modules/content_translation/content_translation.admin.inc #2081151: Remove Unused local variables from the content_translation module Assigned to: beowulf1416
/core/modules/field/tests/modules/field_test/lib/Drupal/field_test/Plugin/field/widget/TestFieldWidgetMultiple.php #2080625: Remove unused local variables for the field module
/core/modules/aggregator/lib/Drupal/aggregator/Tests/CategorizeFeedItemTest.php #2080697: Remove Unused local variable $category from /core/modules/aggregator/lib/Drupal/aggregator/Tests/CategorizeFeedItemTest.php
/core/modules/xmlrpc/xmlrpc.server.inc #2080709: Remove unused local variables from the XMLRPC module
/core/modules/syslog/lib/Drupal/syslog/Tests/SyslogTest.php #2081115: Remove Unused local variables from the syslog module
/core/modules/forum/lib/Drupal/forum/Tests/ForumTest.php #2080543: Remove unused local variables in the forum module Assigned to: larowlan
/core/modules/image/lib/Drupal/image/Tests/ImageFieldValidateTest.php #2080395: Remove unused local variables from the image module
/core/modules/contact/contact.pages.inc #2080423: Remove unused local variables from the contact module
/core/modules/system/lib/Drupal/system/Tests/Database/DeleteTruncateTest.php #2080117: Add assertion to Drupal/system/Tests/Database/DeleteTruncateTest.php
/core/lib/Drupal/Core/Cache/BackendChain.php #2079857: BackendChain::removeBin() is broken
core/lib/Drupal/Core/Routing/MatcherDumper.php #2067551: /core/lib/Drupal/Core/Routing/MatcherDumper.php will never roll back its transaction Assigned to: lokapujya
core/includes/common.inc #2002708: Remove unused local variables from core/includes/common.inc Assigned to: rahul.shinde
/core/modules/system/lib/Drupal/system/Tests/Ajax/ElementValidationTest.php #2080353: Remove Unused local variable $web_user from /core/modules/system/lib/Drupal/system/Tests/Ajax/ElementValidationTest.php
/core/modules/system/lib/Drupal/system/Tests/Menu/BreadcrumbTest.php #2080361: Remove Unused local variable $tree from /core/modules/system/lib/Drupal/system/Tests/Menu/BreadcrumbTest.php
/core/modules/system/lib/Drupal/system/Tests/Lock/LockFunctionalTest.php #2080331: Remove Unused local variable $lock_not_acquired_exit from lib/Drupal/system/Tests/Lock/LockFunctionalTest.php
/core/modules/system/lib/Drupal/system/Tests/Database/DatabaseTestBase.php #2080121: Remove Unused local variable $ringo from /core/modules/system/lib/Drupal/system/Tests/Database/DatabaseTestBase.php Assigned to: justinchev
/core/modules/system/lib/Drupal/system/Tests/Database/SelectOrderedTest.php #2080289: Remove Unused local variable $name_field from /core/modules/system/lib/Drupal/system/Tests/Database/SelectOrderedTest.php Assigned to: pieterjd
/core/modules/views/lib/Drupal/views/Plugin/views/area/Result.php #2072601: Remove Unused local variable $count from /core/modules/views/lib/Drupal/views/Plugin/views/area/Result.php
/core/modules/views/lib/Drupal/views/Tests/ViewStorageTest.php #2072613: Remove Unused local variable $view from /core/modules/views/lib/Drupal/views/Tests/ViewStorageTest.php
/core/modules/views/lib/Drupal/views/Tests/Handler/FieldWebTest.php #2072617: Remove Unused local variable $base from /core/modules/views/lib/Drupal/views/Tests/Handler/FieldWebTest.php
/core/modules/serialization/lib/Drupal/serialization/RegisterSerializationClassesCompilerPass.php #2081175: Remove Unused local variable $id from /serialization/lib/Drupal/serialization/RegisterSerializationClassesCompilerPass.php
/core/modules/menu_link/lib/Drupal/menu_link/MenuLinkStorageController.php #2081177: Remove Unused local variable $entity_class from /core/modules/menu_link/lib/Drupal/menu_link/MenuLinkStorageController.php
/core/modules/tour/tour.module #2081187: Remove Unused local variable $tour_items from /core/modules/tour/tour.module
/core/modules/language/lib/Drupal/language/HttpKernel/PathProcessorLanguage.php #2081189: Remove Unused local variable $host from /core/modules/language/lib/Drupal/language/HttpKernel/PathProcessorLanguage.php
/core/modules/views_ui/views_ui.module #2081193: Remove Unused local variable $display from /core/modules/views_ui/views_ui.module
/core/modules/views_ui/lib/Drupal/views_ui/Form/Ajax/ConfigItemGroup.php #2080047: Remove Unused local variable from views_ui module
/core/modules/views_ui/lib/Drupal/views_ui/Form/Ajax/Display.php #2080033: Remove Unused local variable $section from /core/modules/views_ui/lib/Drupal/views_ui/Form/Ajax/Display.php
/core/modules/ckeditor/ckeditor.admin.inc #2081171: Remove Unused local variable $plugin from /core/modules/ckeditor/ckeditor.admin.inc
/core/modules/block/custom_block/lib/Drupal/custom_block/CustomBlockStorageController.php #2081167: Remove Unused local variable $id from /core/modules/block/custom_block/lib/Drupal/custom_block/CustomBlockStorageController.php
/core/modules/filter/lib/Drupal/filter/Plugin/Filter/FilterCaption.php #2081155: Remove Unused local variable $search from /core/modules/filter/lib/Drupal/filter/Plugin/Filter/FilterCaption.php
/core/modules/content_translation/content_translation.module #2081149: Remove Unused local variable $entity_position from /core/modules/content_translation/content_translation.module
/core/modules/taxonomy/lib/Drupal/taxonomy/Tests/Views/TaxonomyTestBase.php #2081131: Remove Unused local variable $type from /core/modules/taxonomy/lib/Drupal/taxonomy/Tests/Views/TaxonomyTestBase.php
/core/includes/menu.inc #2081133: Remove Unused local variable from /core/includes/menu.inc
/core/modules/tracker/tracker.module #2080715: Remove Unused local variable $keep_subscription from /core/modules/tracker/tracker.module
/core/modules/config/lib/Drupal/config/Tests/ConfigImportUITest.php #2080717: Remove Unused local variable $storage from /core/modules/config/lib/Drupal/config/Tests/ConfigImportUITest.php
/core/modules/aggregator/lib/Drupal/aggregator/Tests/AggregatorTestBase.php #2080699: Remove Unused local variable $items from /core/modules/aggregator/lib/Drupal/aggregator/Tests/AggregatorTestBase.php
/core/modules/rdf/lib/Drupal/rdf/Tests/TrackerAttributesTest.php #2080705: Remove Unused local variable $user from /core/modules/rdf/lib/Drupal/rdf/Tests/TrackerAttributesTest.php
/core/modules/picture/lib/Drupal/picture/Plugin/Core/Entity/PictureMapping.php #2080583: Remove Unused local variable $breakpoint from /core/modules/picture/lib/Drupal/picture/Entity/PictureMapping.php
/core/modules/user/lib/Drupal/user/Tests/UserLanguageTest.php #2080597: Remove Unused local variable $base_url from /core/modules/user/lib/Drupal/user/Tests/UserLanguageTest.php
/core/modules/user/lib/Drupal/user/Tests/UserRegistrationTest.php #2080601: Remove Unused local variable $new_user from /core/modules/user/lib/Drupal/user/Tests/UserRegistrationTest.php
/core/modules/user/lib/Drupal/user/Tests/Views/HandlerFieldUserNameTest.php #2080605: Remove Unused local variable $username from /core/modules/user/lib/Drupal/user/Tests/Views/HandlerFieldUserNameTest.php
/core/modules/user/lib/Drupal/user/Tests/Views/HandlerFieldRoleTest.php #2080607: Remove Unused local variable $rid_a from /core/modules/user/lib/Drupal/user/Tests/Views/HandlerFieldRoleTest.php
/core/modules/field/lib/Drupal/field/Tests/Views/HandlerFieldFieldTest.php #2080671: Remove Unused local variable $key from /core/modules/field/lib/Drupal/field/Tests/Views/HandlerFieldFieldTest.php Assigned to: royal121
/core/modules/update/update.report.inc #2080685: Remove Unused local variable $notification_level from /core/modules/update/update.report.inc
/core/modules/update/update.fetch.inc #2080689: Remove Unused local variable $key from /core/modules/update/update.fetch.inc
/core/modules/search/lib/Drupal/search/SearchQuery.php #2080551: Remove Unused local variable $total from /core/modules/search/lib/Drupal/search/SearchQuery.php
/core/modules/locale/lib/Drupal/locale/Tests/LocaleContentTest.php #2080527: Remove Unused local variable $base_url from /core/modules/locale/lib/Drupal/locale/Tests/LocaleContentTest.php
/core/modules/options/lib/Drupal/options/Tests/OptionsFieldUITest.php #2080535: Remove Unused local variable $allowed_values from /core/modules/options/lib/Drupal/options/Tests/OptionsFieldUITest.php
/core/modules/editor/lib/Drupal/editor/Tests/EditorLoadingTest.php #2080425: Remove Unused local variable $settings from /core/modules/editor/lib/Drupal/editor/Tests/EditorLoadingTest.php
/core/modules/simpletest/simpletest.module #2080397: Remove Unused local variable $group from /core/modules/simpletest/simpletest.module
/core/modules/simpletest/lib/Drupal/simpletest/WebTestBase.php #2080399: Remove Unused local variable $user from /core/modules/simpletest/lib/Drupal/simpletest/WebTestBase.php
/core/modules/simpletest/lib/Drupal/simpletest/Tests/DrupalUnitTestBaseTest.php #2080403: Remove Unused local variable $display from /core/modules/simpletest/lib/Drupal/simpletest/Tests/DrupalUnitTestBaseTest.php
/core/modules/simpletest/lib/Drupal/simpletest/Tests/MailCaptureTest.php #2080405: Remove Unused local variable $response from /core/modules/simpletest/lib/Drupal/simpletest/Tests/MailCaptureTest.php
/core/modules/book/book.module #2080411: Remove Unused local variable $curr from /core/modules/book/book.module
/core/modules/book/lib/Drupal/book/Tests/BookTest.php #2080421: Remove Unused local variable $nodes from /core/modules/book/lib/Drupal/book/Tests/BookTest.php
/core/modules/system/lib/Drupal/system/Tests/FileTransfer/TestFileTransfer.php #2080365: Remove Unused local variable $port from /core/modules/system/lib/Drupal/system/Tests/FileTransfer/TestFileTransfer.php
/core/modules/statistics/lib/Drupal/statistics/Tests/StatisticsLoggingTest.php #2080371: Remove Unused local variable $expected from /core/modules/statistics/lib/Drupal/statistics/Tests/StatisticsLoggingTest.php
/core/modules/rest/lib/Drupal/rest/Tests/ReadTest.php #2080373: Remove Unused local variable $response from /core/modules/rest/lib/Drupal/rest/Tests/ReadTest.php
/core/modules/image/lib/Drupal/image/Tests/ImageThemeFunctionTest.php #2080393: Remove Unused local variable $path from /core/modules/image/lib/Drupal/image/Tests/ImageThemeFunctionTest.php
/core/modules/system/lib/Drupal/system/Tests/Ajax/DialogTest.php #2080357: Remove Unused local variable $dialog_js_exists from /core/modules/system/lib/Drupal/system/Tests/Ajax/DialogTest.php
/core/modules/system/lib/Drupal/system/Tests/Database/CaseSensitivityTest.php #2080291: Remove Unused local variable $john from /core/modules/system/lib/Drupal/system/Tests/Database/CaseSensitivityTest.php Assigned to: justinchev
/core/modules/system/lib/Drupal/system/Tests/Database/SchemaTest.php #2080295: Remove Unused local variable $ret from /core/modules/system/lib/Drupal/system/Tests/Database/SchemaTest.php
/core/modules/system/lib/Drupal/system/Tests/Database/LoggingTest.php #2080303: Remove Unused local variable $log from /core/modules/system/lib/Drupal/system/Tests/Database/LoggingTest.php
/core/modules/system/lib/Drupal/system/Tests/Database/FetchTest.php #2080305: Remove Unused local variable $records from /core/modules/system/lib/Drupal/system/Tests/Database/FetchTest.php
/core/modules/system/lib/Drupal/system/Tests/Database/AlterTest.php #2080309: Remove Unused local variable $record from /core/modules/system/lib/Drupal/system/Tests/Database/AlterTest.php
/core/modules/system/lib/Drupal/system/Tests/Database/InsertDefaultsTest.php #2080119: Remove Unused local variable $result from /core/modules/system/lib/Drupal/system/Tests/Database/InsertDefaultsTest.php
/core/lib/Drupal/Component/Archiver/ArchiveTar.php #2080055: Remove Unused local variable $v_result from /core/lib/Drupal/Component/Archiver/ArchiveTar.php
/core/modules/node/lib/Drupal/node/Tests/Views/StatusExtraTest.php #2079981: Remove Unused local variable $column_map from /core/modules/node/lib/Drupal/node/Tests/Views/StatusExtraTest.php
/core/modules/system/lib/Drupal/system/Form/ImageToolkitForm.php #2080013: Remove Unused local variable $id from /core/modules/system/lib/Drupal/system/Form/ImageToolkitForm.php
/core/modules/datetime/datetime.module #2080067: Remove Unused local variable $has_time from /core/modules/datetime/datetime.module
/core/modules/system/lib/Drupal/system/Tests/Form/ElementsTableSelectTest.php #2080095: Remove Unused local variable $processed_form from /core/modules/system/lib/Drupal/system/Tests/Form/ElementsTableSelectTest.php
/core/modules/system/lib/Drupal/system/Tests/Plugin/CacheDecoratorTest.php #2080105: Remove Unused local variable $conf from /core/modules/system/lib/Drupal/system/Tests/Plugin/CacheDecoratorTest.php
/core/modules/system/lib/Drupal/system/Tests/Plugin/CacheDecoratorLanguageTest.php #2080113: Remove Unused local variable $plugin_id from /core/modules/system/lib/Drupal/system/Tests/Plugin/CacheDecoratorLanguageTest.php
/core/modules/system/lib/Drupal/system/Tests/Cache/GenericCacheBackendUnitTestBase.php #2080115: Remove Unused local variable $cached from /core/modules/system/lib/Drupal/system/Tests/Cache/GenericCacheBackendUnitTestBase.php
/core/modules/views/lib/Drupal/views/Tests/Handler/FilterDateTest.php #2072625: Remove Unused local variable $view from /core/modules/views/lib/Drupal/views/Tests/Handler/FilterDateTest.php
/core/modules/views/lib/Drupal/views/Tests/ModuleTest.php #2072609: Remove Unused local variable $id from /core/modules/views/lib/Drupal/views/Tests/ModuleTest.php
/core/modules/views/lib/Drupal/views/ManyToOneHelper.php #2067529: Remove Unused local variable $alias from /core/modules/views/lib/Drupal/views/ManyToOneHelper.php Assigned to: mrded
/core/modules/views/lib/Drupal/views/Plugin/views/display/DisplayPluginBase.php #2072593: Remove Unused local variable $id from /core/modules/views/lib/Drupal/views/Plugin/views/display/DisplayPluginBase.php
/core/modules/system/lib/Drupal/system/Tests/Common/JavaScriptTest.php #2080321: Remove Unused local variable $result from /core/modules/system/lib/Drupal/system/Tests/Common/JavaScriptTest.php
core/includes/* #2002704: Remove unused local variables from files in core/includes
core/includes/authorize.inc #2002706: Improve code maintainability by removing unused local variables - core/includes/authorize.inc Assigned to: kerasai
core/includes/file.inc #2002714: Remove unused local variables - core/includes/file.inc Assigned to: neochief
core/includes/install.core.inc #2002720: Remove unused local variables - core/includes/install.core.inc Assigned to: neochief
core/includes/install.inc #2002722: Improve maintainability by removing unused local variables - core/includes/install.inc
core/includes/module.inc #2002728: Improve performance by removing unused local variables - core/includes/module.inc Assigned to: lajical
core/includes/theme.inc #2002730: Improve code maintainability by removing unused local variables - core/includes/theme.inc
core/includes/update.inc #2002732: Improve code maintainability by removing unused local variables - core/includes/update.inc Assigned to: diarmy
core/lib/Drupal/Core/Config/Entity/ConfigStorageController.php #2062221: Remove Unused local variable $id from /core/lib/Drupal/Core/Config/Entity/ConfigStorageController.php
core/lib/Drupal/Core/Config/Entity/Query/Condition.php #2062225: Remove Unused local variable $candidates from /core/lib/Drupal/Core/Config/Entity/Query/Condition.php
core/lib/Drupal/Core/Database/StatementPrefetch.php #2060811: Remove Unused local variable $column from /core/lib/Drupal/Core/Database/StatementPrefetch.php
core/lib/Drupal/Core/Database/Driver/mysql/Schema.php #2060813: Remove Unused local variable $info from /core/lib/Drupal/Core/Database/Driver/mysql/Schema.php
core/lib/Drupal/Core/Database/Driver/pgsql/Schema.php #2060815: Remove Unused local variable $field_information from /core/lib/Drupal/Core/Database/Driver/pgsql/Schema.php
core/lib/Drupal/Core/Database/Driver/pgsql/Update.php #2060817: Remove Unused local variable $expression_fields from /core/lib/Drupal/Core/Database/Driver/pgsql/Update.php
core/lib/Drupal/Core/Database/Driver/sqlite/Connection.php #2060819: Remove Unused local variable $table from /core/lib/Drupal/Core/Database/Driver/sqlite/Connection.php
core/lib/Drupal/Core/Database/Query/Select.php #2060821: Remove Unused local variable $alias from /core/lib/Drupal/Core/Database/Query/Select.php
core/lib/Drupal/Core/Database/Query/Update.php #2060823: Remove Unused local variable $field from /core/lib/Drupal/Core/Database/Query/Update.php
core/lib/Drupal/Core/EventSubscriber/RequestCloseSubscriber.php #2062237: Remove Unused local variable $request_method from /core/lib/Drupal/Core/EventSubscriber/RequestCloseSubscriber.php
core/lib/Drupal/Core/Extension/ModuleHandler.php #2062233: Remove Unused local variable $name from /core/lib/Drupal/Core/Extension/ModuleHandler.php
core/lib/Drupal/Core/Path/AliasManager.php #2062245: Remove Unused local variable $original_path from /core/lib/Drupal/Core/Path/AliasManager.php
core/lib/Drupal/Core/Routing/RouteProvider.php #2062519: Remove Unused local variable $return from /core/lib/Drupal/Core/Routing/RouteProvider.php
core/lib/Drupal/Core/StreamWrapper/LocalStream.php #2062213: Remove Unused local variable $scheme from /core/lib/Drupal/Core/StreamWrapper/LocalStream.php
core/lib/Drupal/Core/SystemListing.php #2062187: Remove Unused local variable $files from /core/lib/Drupal/Core/SystemListing.php
core/lib/Drupal/Core/Utility/ThemeRegistry.php #2062241: Remove Unused local variable $data from /core/lib/Drupal/Core/Utility/ThemeRegistry.php
core/update.php #2056415: Remove Unused local variable $function from /core/update.php
core/modules/block/block.module #2057149: Remove Unused local variable $block_counter from /core/modules/block/block.module
core/modules/block/lib/Drupal/block/Plugin/PluginUI/BlockPluginUI.php #2062175: Remove Unused local variable $plugin from /core/modules/block/lib/Drupal/block/Plugin/PluginUI/BlockPluginUI.php Assigned to: duozersk
core/modules/ckeditor/lib/Drupal/ckeditor/Plugin/Editor/CKEditor.php #2060715: Remove Unused local variable $module_path from /core/modules/ckeditor/lib/Drupal/ckeditor/Plugin/Editor/CKEditor.php
/core/modules/file/file.views.inc #2072545: Remove Unused local variable $all_labels from /core/modules/file/file.views.inc
/core/modules/file/file.module #2072549: Remove Unused local variable $file_path from /core/modules/file/file.module
/core/modules/file/file.field.inc #2072551: Remove Unused local variable $delta from /core/modules/file/file.field.inc
/core/modules/file/lib/Drupal/file/Plugin/field/widget/FileWidget.php #2072553: Remove Unused local variable $wrapper_id from /core/modules/file/lib/Drupal/file/Plugin/field/widget/FileWidget.php
/core/modules/file/lib/Drupal/file/Tests/FileFieldValidateTest.php #2072555: Remove Unused local variable $langcode from /core/modules/file/lib/Drupal/file/Tests/FileFieldValidateTest.php
/core/modules/file/lib/Drupal/file/Tests/FileFieldRevisionTest.php #2072557: Remove Unused local variable $node_vid_r4 from /core/modules/file/lib/Drupal/file/Tests/FileFieldRevisionTest.php
/core/modules/file/lib/Drupal/file/Tests/DownloadTest.php #2072559: Remove Unused local variable $generator from /core/modules/file/lib/Drupal/file/Tests/DownloadTest.php
/core/modules/file/lib/Drupal/file/Tests/SaveUploadTest.php #2072561: Remove Unused local variable $max_fid_before from /core/modules/file/lib/Drupal/file/Tests/SaveUploadTest.php
/core/modules/file/lib/Drupal/file/Tests/FileTokenReplaceTest.php #2072563: Remove Unused local variable $url_options from /core/modules/file/lib/Drupal/file/Tests/FileTokenReplaceTest.php
/core/modules/file/lib/Drupal/file/Tests/FileFieldWidgetTest.php #2072565: Remove Unused local variable $text_file from /core/modules/file/lib/Drupal/file/Tests/FileFieldWidgetTest.php
core/modules/system/lib/Drupal/system/Plugin/Block/SystemMenuBlock.php #2060721: Remove Unused local variable $plugin from /core/modules/system/lib/Drupal/system/Plugin/Block/SystemMenuBlock.php
core/modules/system/lib/Drupal/system/Plugin/ImageToolkit/GDToolkit.php #2060723: Remove Unused local variable $width from /core/modules/system/lib/Drupal/system/Plugin/ImageToolkit/GDToolkit.php
core/modules/views/lib/Drupal/views/Plugin/Block/ViewsBlock.php #2060725: Remove Unused local variable $plugin from /core/modules/views/lib/Drupal/views/Plugin/Block/ViewsBlock.php
core/modules/rdf/lib/Drupal/rdf/Tests/UserAttributesTest.php #2056417: Remove Unused local variable $person_uri from /core/modules/rdf/lib/Drupal/rdf/Tests/UserAttributesTest.php Assigned to: Marcus Maihoff
core/modules/language/lib/Drupal/language/Plugin/Block/LanguageBlock.php #2056685: Remove Unused local variable $plugin_id from /core/modules/language/lib/Drupal/language/Plugin/Block/LanguageBlock.php Assigned to: jan.stoeckler
core/modules/field/lib/Drupal/field/Tests/FieldImportCreateTest.php #2056761: Remove Unused local variable $instance_2a from /core/modules/field/lib/Drupal/field/Tests/FieldImportCreateTest.php Assigned to: jan.stoeckler
core/modules/field/lib/Drupal/field/Plugin/Core/Entity/FieldInstance.php #2056827: Remove Unused local variable $module_handler from /core/modules/field/lib/Drupal/field/Plugin/Core/Entity/FieldInstance.php Assigned to: jan.stoeckler
core/modules/node/node.module #2062585: Remove Unused local variables from /core/modules/node/node.module
core/modules/node/node.pages.inc #2062581: Remove Unused local variable $output from /core/modules/node/node.pages.inc
core/modules/node/lib/Drupal/node/NodeRenderController.php #2062589: Remove Unused local variable $key from /core/modules/node/lib/Drupal/node/NodeRenderController.php
core/modules/node/lib/Drupal/node/Plugin/Core/Entity/Node.php #2062753: Remove Unused local variable $id from /core/modules/node/lib/Drupal/node/Plugin/Core/Entity/Node.php /td>
core/modules/node/lib/Drupal/node/Tests/NodePostSettingsTest.php #2064271: Remove Unused local variable $node from /core/modules/node/lib/Drupal/node/Tests/NodePostSettingsTest.php
core/modules/node/lib/Drupal/node/Tests/PageViewTest.php #2064277: Remove Unused local variable $html from /core/modules/node/lib/Drupal/node/Tests/PageViewTest.php
core/modules/node/lib/Drupal/node/Tests/NodeAccessBaseTableTest.php #2064641: Remove Unused local variable $uid from /core/modules/node/lib/Drupal/node/Tests/NodeAccessBaseTableTest.php
modules/testswarm/testswarm.pages.inc #2056833: Remove Unused local variable $current_karma from /modules/testswarm/testswarm.pages.inc
core/modules/locale/lib/Drupal/locale/LocaleConfigManager.php #2057019: Remove Unused local variable $string from /core/modules/locale/lib/Drupal/locale/LocaleConfigManager.php Assigned to: jan.stoeckler
core/modules/menu/lib/Drupal/menu/Plugin/Block/MenuBlock.php #2061343: Remove Unused local variable $plugin from /core/modules/menu/lib/Drupal/menu/Plugin/Block/MenuBlock.php
core/modules/php/lib/Drupal/php/Plugin/Filter/Php.php #2061387: Remove Unused local variable $base_url from /core/modules/php/lib/Drupal/php/Plugin/Filter/Php.php
core/modules/user/user.module #2057137: Remove Unused local variable $user from /core/modules/user/user.module
/core/modules/views/views.theme.inc #2064289: Remove Unused local variables from /core/modules/views/views.theme.inc
/core/modules/views/views.tokens.inc #2065115: Remove Unused local variable $langcode from /core/modules/views/views.tokens.inc
/core/modules/views/lib/Drupal/views/DisplayBag.php #2065125: Remove Unused local variable $display_id from /core/modules/views/lib/Drupal/views/DisplayBag.php
/core/modules/views/lib/Drupal/views/ViewStorageController.php #2067541: Remove Unused local variable $id from /core/modules/views/lib/Drupal/views/ViewStorageController.php Assigned to: jlindsey15
/core/modules/views/lib/Drupal/views/ViewExecutable.php #2072583: Remove Unused local variable $converted from /core/modules/views/lib/Drupal/views/ViewExecutable.php
/core/modules/views/lib/Drupal/views/Plugin/views/exposed_form/InputRequired.php #2072587: Remove Unused local variable $filter_id from /core/modules/views/lib/Drupal/views/Plugin/views/exposed_form/InputRequired.php
/core/modules/views/lib/Drupal/views/Plugin/views/join/Subquery.php #2072589: Remove Unused local variable $extra from /core/modules/views/lib/Drupal/views/Plugin/views/join/Subquery.php
/core/modules/views/lib/Drupal/views/Plugin/views/join/JoinPluginBase.php #2072591: Remove Unused local variable $extra from /core/modules/views/lib/Drupal/views/Plugin/views/join/JoinPluginBase.php
/core/modules/views/lib/Drupal/views/Plugin/views/relationship/GroupwiseMax.php #2072595: Remove Unused local variable $base_field from /core/modules/views/lib/Drupal/views/Plugin/views/relationship/GroupwiseMax.php
/core/modules/views/lib/Drupal/views/Plugin/views/filter/String.php #2072599: Remove Unused local variable $placeholder from /core/modules/views/lib/Drupal/views/Plugin/views/filter/String.php
/core/modules/views/lib/Drupal/views/Plugin/views/query/Sql.php #2072603: Remove Unused local variable $key from /core/modules/views/lib/Drupal/views/Plugin/views/query/Sql.php
/core/modules/views/lib/Drupal/views/Plugin/views/style/StylePluginBase.php #2072607: Remove Unused local variable $fake_item from /core/modules/views/lib/Drupal/views/Plugin/views/style/StylePluginBase.php
/core/modules/views/lib/Drupal/views/Tests/GlossaryTest.php #2072611: Remove Unused local variable $result_nodes_per_char from /core/modules/views/lib/Drupal/views/Tests/GlossaryTest.php
/core/modules/views/lib/Drupal/views/Tests/Plugin/PagerTest.php #2072615: Remove Unused local variable $edit from /core/modules/views/lib/Drupal/views/Tests/Plugin/PagerTest.php
/core/modules/views/lib/Drupal/views/Tests/Handler/RelationshipTest.php #2072619: Remove Unused local variable $key from /core/modules/views/lib/Drupal/views/Tests/Handler/RelationshipTest.php
/core/modules/views/lib/Drupal/views/Tests/Handler/ArgumentNullTest.php #2072621: Remove Unused local variable $string from /core/modules/views/lib/Drupal/views/Tests/Handler/ArgumentNullTest.php
/core/modules/views/lib/Drupal/views/Tests/Handler/FieldUnitTest.php #2072623: Remove Unused local variable $empty_text from /core/modules/views/lib/Drupal/views/Tests/Handler/FieldUnitTest.php
core/modules/views/lib/Drupal/views/Plugin/views/HandlerBase.php #2067547: Remove Unused local variable $display_id from /core/modules/views/lib/Drupal/views/Plugin/views/HandlerBase.php
core/modules/views/views.module #2057157: Remove Unused local variable $plugin from /core/modules/views/views.module
core/modules/views_ui/lib/Drupal/views_ui/Tests/RowUITest.php #2062755: Remove Unused local variable $view from /core/modules/views_ui/lib/Drupal/views_ui/Tests/RowUITest.php
core/modules/views_ui/lib/Drupal/views_ui/Tests/StyleUITest.php #2062179: Remove Unused local variable $view from /core/modules/views_ui/lib/Drupal/views_ui/Tests/StyleUITest.php
core/themes/seven/seven.theme #2062161: Remove Unused local variable $output from /core/themes/seven/seven.theme
core/themes/engines/twig/twig.engine #2062133: Remove Unused local variable $key from /core/themes/engines/twig/twig.engine
#2062191: Remove Unused local variables from EntityNG, DatabaseStorageControllerNG, and DatabaseStorageController
/core/lib/Drupal/Component/Gettext/PoHeader.php #2080051: Remove Unused local variable $default from /core/lib/Drupal/Component/Gettext/PoHeader.php
/core/modules/node/lib/Drupal/node/Tests/NodeAccessLanguageTest.php #2080053: Remove Unused local variable $expected_node_access from /core/modules/node/lib/Drupal/node/Tests/NodeAccessLanguageTest.php
/core/modules/node/lib/Drupal/node/Tests/NodeFormButtonsTest.php #2080057: Fix assertion in NodeFormButtonsTest.php
/core/modules/node/lib/Drupal/node/Tests/NodeTranslationUITest.php #2080059: Remove Unused local variable $index from /core/modules/node/lib/Drupal/node/Tests/NodeTranslationUITest.php
/core/modules/node/lib/Drupal/node/Tests/Views/FilterUidRevisionTest.php #2080065: Remove Unused local variable $node from /core/modules/node/lib/Drupal/node/Tests/Views/FilterUidRevisionTest.php Assigned to: littledynamo
/core/modules/system/lib/Drupal/system/Form/PerformanceForm.php #2080019: Remove Unused local variable $js_hide from /core/modules/system/lib/Drupal/system/Form/PerformanceForm.php
/core/modules/views/includes/ajax.inc #2080023: Remove Unused local variable $tid from /core/modules/views/includes/ajax.inc
/core/modules/system/system.admin.inc #2080069: Remove Unused local variable $stripe from /core/modules/system/system.admin.inc
/core/modules/system/system.install #2080071: Remove Unused local variable $base_url from /core/modules/system/system.install
/core/modules/system/system.api.php #2080073: Remove Unused local variable $group from /core/modules/system/system.api.php
/core/modules/system/system.module #2080075: Remove Unused local variable $plugin_id from /core/modules/system/system.module
/core/modules/system/tests/modules/error_test/error_test.module #2080077: Remove Unused local variable $monkey_love from /core/modules/system/tests/modules/error_test/error_test.module
/core/modules/system/tests/modules/database_test/database_test.module #2080091: Remove Unused local variable $name_field from /core/modules/system/tests/modules/database_test/database_test.module
/core/modules/system/lib/Drupal/system/Tests/Form/FormTest.php #2080093: Remove Unused local variable $form from /core/modules/system/lib/Drupal/system/Tests/Form/FormTest.php
/core/modules/system/lib/Drupal/system/Tests/Entity/EntityFieldTest.php #2080097: Remove Unused local variable $name from /core/modules/system/lib/Drupal/system/Tests/Entity/EntityFieldTest.php
/core/modules/system/lib/Drupal/system/Tests/Entity/EntityCrudHookTest.php #2080099: Remove Unused local variable $entity from /core/modules/system/lib/Drupal/system/Tests/Entity/EntityCrudHookTest.php
/core/modules/system/lib/Drupal/system/Tests/Entity/EntityRevisionsTest.php #2080101: Remove Unused local variable $entities from /core/modules/system/lib/Drupal/system/Tests/Entity/EntityRevisionsTest.php
/core/modules/system/lib/Drupal/system/Tests/Image/ToolkitGdTest.php #2080103: Remove Unused local variable $correct_colors from /core/modules/system/lib/Drupal/system/Tests/Image/ToolkitGdTest.php
/core/modules/system/lib/Drupal/system/Tests/Database/SelectComplexTest.php #2080317: Remove Unused local variable $task_field from /core/modules/system/lib/Drupal/system/Tests/Database/SelectComplexTest.php Assigned to: rhm50
/core/tests/Drupal/Tests/Core/Database/EmptyStatementTest.php #2080299: Remove Unused local variable $record from /core/tests/Drupal/Tests/Core/Database/EmptyStatementTest.php
/core/tests/Drupal/Tests/Core/Entity/EntityCreateAccessCheckTest.php #2080319: Remove Unused local variable $entity from /core/tests/Drupal/Tests/Core/Entity/EntityCreateAccessCheckTest.php
/core/modules/system/lib/Drupal/system/Tests/Common/WriteRecordTest.php #2080325: Remove Unused local variable $insert_result from /core/modules/system/lib/Drupal/system/Tests/Common/WriteRecordTest.php
/core/modules/system/lib/Drupal/system/Tests/Common/AddFeedTest.php #2080327: Remove Unused local variable $description from /core/modules/system/lib/Drupal/system/Tests/Common/AddFeedTest.php
/core/modules/system/lib/Drupal/system/Tests/File/ReadOnlyStreamWrapperTest.php #2080333: Remove Unused local variable $instance from /core/modules/system/lib/Drupal/system/Tests/File/ReadOnlyStreamWrapperTest.php
/core/modules/system/lib/Drupal/system/Tests/Mail/MailTest.php #2080337: Remove Unused local variable $message from /core/modules/system/lib/Drupal/system/Tests/Mail/MailTest.php
/core/modules/system/lib/Drupal/system/Tests/Routing/RouteProviderTest.php #2080339: Remove Unused local variable $routes from /core/modules/system/lib/Drupal/system/Tests/Routing/RouteProviderTest.php
/core/modules/system/lib/Drupal/system/Tests/System/CronRunTest.php #2080345: Remove Unused local variable $base_url from /core/modules/system/lib/Drupal/system/Tests/System/CronRunTest.php
/core/modules/system/lib/Drupal/system/Tests/System/TokenReplaceTest.php #2080347: Remove Unused local variable $result from /core/modules/system/lib/Drupal/system/Tests/System/TokenReplaceTest.php
/core/modules/system/lib/Drupal/system/Tests/Ajax/MultiFormTest.php #2080351: Remove Unused local variable $form_html_id from /core/modules/system/lib/Drupal/system/Tests/Ajax/MultiFormTest.php
/core/modules/system/lib/Drupal/system/Tests/Ajax/FrameworkTest.php #2080359: Remove Unused local variable $new_css from /core/modules/system/lib/Drupal/system/Tests/Ajax/FrameworkTest.php
/core/modules/system/lib/Drupal/system/Tests/Menu/RebuildTest.php #2080363: Remove Unused local variable $delete from /core/modules/system/lib/Drupal/system/Tests/Menu/RebuildTest.php
/core/tests/Drupal/Tests/Component/PhpStorage/MTimeProtectedFileStorageTest.php #2080367: Remove Unused local variable $storageFactory from core/tests/Drupal/Tests/Component/PhpStorage/MTimeProtectedFileStorageTest.php
/core/modules/statistics/statistics.tokens.inc #2080369: Remove Unused local variable $url_options from /core/modules/statistics/statistics.tokens.inc
/core/modules/text/lib/Drupal/text/Tests/TextFieldTest.php #2080375: Remove Unused local variable $entity_type from /core/modules/text/lib/Drupal/text/Tests/TextFieldTest.php
/core/modules/text/lib/Drupal/text/Tests/TextSummaryTest.php #2080383: Remove Unused local variable $i from /core/modules/text/lib/Drupal/text/Tests/TextSummaryTest.php
/core/modules/image/image.views.inc #2080389: Remove Unused local variable $all_labels from /core/modules/image/image.views.inc
/core/modules/image/image.module #2080391: Remove Unused local variables from multiple core files
/core/modules/simpletest/lib/Drupal/simpletest/Tests/SimpleTestTest.php #2080401: Remove Unused local variable $conf from /core/modules/simpletest/lib/Drupal/simpletest/Tests/SimpleTestTest.php
/core/modules/book/book.admin.inc #2080409: Remove Unused local variable $langcode from /core/modules/book/book.admin.inc
/core/modules/views_ui/lib/Drupal/views_ui/Tests/RedirectTest.php #2080413: Remove Unused local variable $view from /core/modules/views_ui/lib/Drupal/views_ui/Tests/RedirectTest.php
/core/modules/language/language.admin.inc #2080429: Remove Unused local variable $mappings from /core/modules/language/language.admin.inc
/core/modules/language/lib/Drupal/language/Tests/LanguageUrlRewritingTest.php #2080431: Remove Unused local variable $request from /core/modules/language/lib/Drupal/language/Tests/LanguageUrlRewritingTest.php
/core/modules/language/lib/Drupal/language/Tests/LanguageListTest.php #2080433: Remove Unused local variable $base_url from /core/modules/language/lib/Drupal/language/Tests/LanguageListTest.php
/core/modules/language/lib/Drupal/language/Tests/LanguageConfigurationTest.php #2080437: Remove Unused local variable $base_url from /core/modules/language/lib/Drupal/language/Tests/LanguageConfigurationTest.php
/core/modules/language/lib/Drupal/language/Tests/LanguageCustomLanguageConfigurationTest.php #2080441: Remove Unused local variable $base_url from language/lib/Drupal/language/Tests/LanguageCustomLanguageConfigurationTest.php
/core/modules/locale/locale.bulk.inc #2080443: Remove Unused local variable $filepath from /core/modules/locale/locale.bulk.inc Assigned to: boran
/core/modules/locale/locale.pages.inc #2080449: Remove Unused local variable $project_id from /core/modules/locale/locale.pages.inc
/core/modules/locale/locale.install #2080459: Remove Unused local variable $project_id from /core/modules/locale/locale.install
/core/modules/locale/locale.module #2080463: Remove Unused local variable $key from /core/modules/locale/locale.module
/core/modules/locale/tests/modules/locale_test/locale_test.module #2080509: Remove Unused local variable $base_url from /core/modules/locale/tests/modules/locale_test/locale_test.module
/core/modules/locale/lib/Drupal/locale/PoDatabaseWriter.php #2080513: Remove Unused local variable $config from /core/modules/locale/lib/Drupal/locale/PoDatabaseWriter.php
/core/modules/locale/lib/Drupal/locale/Tests/LocaleTranslationUiTest.php #2080515: Remove Unused local variable $base_url from /core/modules/locale/lib/Drupal/locale/Tests/LocaleTranslationUiTest.php
/core/modules/locale/lib/Drupal/locale/Tests/LocaleImportFunctionalTest.php #2080517: Remove Unused local variable $config from /core/modules/locale/lib/Drupal/locale/Tests/LocaleImportFunctionalTest.php
/core/modules/locale/lib/Drupal/locale/Tests/LocaleUpdateTest.php #2080519: Remove Unused local variable $config from /core/modules/locale/lib/Drupal/locale/Tests/LocaleUpdateTest.php
/core/modules/locale/lib/Drupal/locale/Tests/LocaleStringTest.php #2080521: Remove Unused local variable $translations from /core/modules/locale/lib/Drupal/locale/Tests/LocaleStringTest.php
/core/modules/locale/lib/Drupal/locale/Tests/LocalePathTest.php #2080525: Remove Unused local variable $base_url from /core/modules/locale/lib/Drupal/locale/Tests/LocalePathTest.php
/core/modules/options/options.api.php #2080529: Remove Unused local variable $options from /core/modules/options/options.api.php
/core/modules/options/options.module #2080533: Remove Unused local variable $value from /core/modules/options/options.module
/core/modules/forum/forum.module #2080537: Remove Unused local variable $output from /core/modules/forum/forum.module
/core/modules/forum/lib/Drupal/forum/Tests/ForumBlockTest.php #2080539: Remove Unused local variable $langcode from /core/modules/forum/lib/Drupal/forum/Tests/ForumBlockTest.php
/core/modules/overlay/overlay.module #2080545: Remove Unused local variable $base_path from /core/modules/overlay/overlay.module
/core/modules/search/search.module #2080549: Remove Unused local variable $module_info from /core/modules/search/search.module
/core/modules/search/lib/Drupal/search/Tests/SearchAdvancedSearchFormTest.php #2080553: Remove Unused local variable $node from /core/modules/search/lib/Drupal/search/Tests/SearchAdvancedSearchFormTest.php
/core/modules/search/lib/Drupal/search/Tests/SearchExcerptTest.php #2080555: Remove Unused local variable $longtext from /core/modules/search/lib/Drupal/search/Tests/SearchExcerptTest.php
/core/modules/search/lib/Drupal/search/Tests/SearchPreprocessLangcodeTest.php #2080557: Remove Unused local variable $node from /core/modules/search/lib/Drupal/search/Tests/SearchPreprocessLangcodeTest.php
/core/modules/dblog/lib/Drupal/dblog/Tests/DbLogTest.php #2080561: Remove Unused local variable from /core/modules/dblog/lib/Drupal/dblog/Tests/DbLogTest.php
/core/modules/comment/comment.admin.inc #2080563: Remove Unused local variable $cid from /core/modules/comment/comment.admin.inc
/core/modules/comment/comment.install #2080565: Remove Unused local variable $type from /core/modules/comment/comment.install
/core/modules/comment/lib/Drupal/comment/Plugin/views/row/Rss.php #2080567: Remove Unused local variable $nids from /core/modules/comment/lib/Drupal/comment/Plugin/views/row/Rss.php
/core/modules/comment/lib/Drupal/comment/Plugin/Core/Entity/Comment.php #2080571: Remove Unused local variable $id from /core/modules/comment/lib/Drupal/comment/Entity/Comment.php
/core/modules/comment/lib/Drupal/comment/Tests/CommentPagerTest.php #2080573: Remove Unused local variable $replies from /core/modules/comment/lib/Drupal/comment/Tests/CommentPagerTest.php
/core/modules/comment/lib/Drupal/comment/Tests/CommentRssTest.php #2080575: Remove Unused local variable $comment from /core/modules/comment/lib/Drupal/comment/Tests/CommentRssTest.php
/core/modules/comment/lib/Drupal/comment/Tests/CommentTokenReplaceTest.php #2080577: Remove Unused local variable $instance from /core/modules/comment/lib/Drupal/comment/Tests/CommentTokenReplaceTest.php
/core/modules/comment/lib/Drupal/comment/Tests/CommentThreadingTest.php #2080579: Remove Unused local variable $langcode from /core/modules/comment/lib/Drupal/comment/Tests/CommentThreadingTest.php
/core/modules/picture/lib/Drupal/picture/Tests/PictureFieldDisplayTest.php #2080587: Remove Unused local variable $breakpoints from /core/modules/picture/lib/Drupal/picture/Tests/PictureFieldDisplayTest.php
/core/modules/picture/lib/Drupal/picture/Tests/PictureAdminUITest.php #2080589: Remove Unused local variable $breakpoints from /core/modules/picture/lib/Drupal/picture/Tests/PictureAdminUITest.php
/core/modules/user/lib/Drupal/user/Plugin/views/field/Language.php #2080591: Remove Unused local variable $uid from /core/modules/user/lib/Drupal/user/Plugin/views/field/Language.php
/core/modules/user/lib/Drupal/user/Plugin/views/filter/Name.php #2080595: Remove Unused local variable $results from /core/modules/user/lib/Drupal/user/Plugin/views/filter/Name.php
/core/modules/user/lib/Drupal/user/Tests/Views/HandlerFilterUserNameTest.php #2080603: Remove Unused local variable $users from /core/modules/user/lib/Drupal/user/Tests/Views/HandlerFilterUserNameTest.php
/core/modules/field/field.info.inc #2080611: Remove Unused local variable $key from /core/modules/field/field.info.inc
/core/modules/field/field.api.php #2080613: Remove Unused local variable $details from /core/modules/field/field.api.php
/core/modules/field/field.form.inc #2080617: Remove Unused local variable $key from /core/modules/field/field.form.inc
/core/modules/field/field.attach.inc #2080619: Remove Unused local variable $field_name from /core/modules/field/field.attach.inc
/core/modules/field/field.views.inc #2080621: Remove Unused local variable $old_column from /core/modules/field/field.views.inc
/core/modules/field/tests/modules/field_test/field_test.storage.inc #2080623: Remove Unused local variable $details from /core/modules/field/tests/modules/field_test/field_test.storage.inc
/core/modules/field/tests/modules/field_test/lib/Drupal/field_test/Plugin/field/formatter/TestFieldPrepareViewFormatter.php #2080627: Remove Unused local variable $delta from /lib/Drupal/field_test/Plugin/field/formatter/TestFieldPrepareViewFormatter.php
/core/modules/field/lib/Drupal/field/FieldInfo.php #2080647: Remove Unused local variable $entity_type_info from /core/modules/field/lib/Drupal/field/FieldInfo.php
/core/modules/field/lib/Drupal/field/Plugin/views/field/Field.php #2080649: Remove Unused local variable $array from /core/modules/field/lib/Drupal/field/Plugin/views/field/Field.php
/core/modules/taxonomy/lib/Drupal/taxonomy/Plugin/field/formatter/TaxonomyFormatterBase.php #2080653: Remove Unused local variable $delta from taxonomy/lib/Drupal/taxonomy/Plugin/field/formatter/TaxonomyFormatterBase.php
/core/modules/locale/lib/Drupal/locale/Tests/LocaleConfigTranslationTest.php #2080655: Remove Unused local variable $language from /core/modules/locale/lib/Drupal/locale/Tests/LocaleConfigTranslationTest.php
/core/modules/field/lib/Drupal/field/Plugin/Type/Widget/WidgetBase.php #2080661: Remove Unused local variable $delta from /core/modules/field/lib/Drupal/field/Plugin/Type/Widget/WidgetBase.php
/core/modules/field/lib/Drupal/field/Tests/CrudTest.php #2080663: Remove Unused local variable $langcode from /core/modules/field/lib/Drupal/field/Tests/CrudTest.php
/core/modules/field/lib/Drupal/field/Tests/DisplayApiTest.php #2080665: Remove Unused local variable $array from /core/modules/field/lib/Drupal/field/Tests/DisplayApiTest.php
/core/modules/field/lib/Drupal/field/Tests/FieldAttachOtherTest.php #2080667: Remove Unused local variable $langcode from /core/modules/field/lib/Drupal/field/Tests/FieldAttachOtherTest.php
/core/modules/field/lib/Drupal/field/Tests/TranslationTest.php #2080669: Remove Unused local variable $delta from /core/modules/field/lib/Drupal/field/Tests/TranslationTest.php
/core/modules/filter/filter.install #2080673: Remove Unused local variable $name from /core/modules/filter/filter.install
/core/modules/filter/lib/Drupal/filter/Tests/FilterCrudTest.php #2080675: Remove Unused local variable $name from /core/modules/filter/lib/Drupal/filter/Tests/FilterCrudTest.php
/core/modules/filter/lib/Drupal/filter/Tests/FilterFormatAccessTest.php #2080677: Remove Unused local variable $title_key from /core/modules/filter/lib/Drupal/filter/Tests/FilterFormatAccessTest.php
/core/modules/update/update.authorize.inc #2080681: Remove Unused local variable $project from /core/modules/update/update.authorize.inc
/core/modules/update/update.module #2080687: Remove Unused local variable $key from /core/modules/update/update.module
/core/modules/layout/layout.module #2080691: Remove Unused local variable $name from /core/modules/layout/layout.module
/core/modules/layout/lib/Drupal/layout/Config/DisplayBase.php #2080693: Remove Unused local variable $layout_regions_indexed from /core/modules/layout/lib/Drupal/layout/Config/DisplayBase.php
/core/modules/aggregator/aggregator.pages.inc #2080695: Remove Unused local variable $items from /core/modules/aggregator/aggregator.pages.inc
/core/modules/aggregator/lib/Drupal/aggregator/Tests/AggregatorCronTest.php #2080701: Remove Unused local variable $base_url from /core/modules/aggregator/lib/Drupal/aggregator/Tests/AggregatorCronTest.php
/core/modules/rdf/rdf.module #2080703: Remove Unused local variable $prefixes from /core/modules/rdf/rdf.module
/core/modules/node/lib/Drupal/node/NodeGrantDatabaseStorage.php #2080707: Remove Unused local variable $base_table_found from /core/modules/node/lib/Drupal/node/NodeGrantDatabaseStorage.php
/core/modules/shortcut/shortcut.module #2080711: Remove Unused local variable $id from /core/modules/shortcut/shortcut.module
/core/modules/shortcut/lib/Drupal/shortcut/Tests/ShortcutTestBase.php #2080713: Remove Unused local variable $uuid from /core/modules/shortcut/lib/Drupal/shortcut/Tests/ShortcutTestBase.php
/core/modules/field_sql_storage/field_sql_storage.module #2080719: Remove Unused local variable $details from /core/modules/field_sql_storage/field_sql_storage.module
/core/modules/field_sql_storage/lib/Drupal/field_sql_storage/Tests/FieldSqlStorageTest.php #2081109: Remove Unused local variable $langcode from field_sql_storage/lib/Drupal/field_sql_storage/Tests/FieldSqlStorageTest.php
/core/modules/color/color.module #2081111: Remove Unused local variable $base_filename from /core/modules/color/color.module
/core/modules/color/lib/Drupal/color/Tests/ColorTest.php #2081113: Remove Unused local variable $key from /core/modules/color/lib/Drupal/color/Tests/ColorTest.php
/core/modules/menu/menu.admin.inc #2081117: Remove Unused local variable $title from /core/modules/menu/menu.admin.inc
/core/modules/taxonomy/taxonomy.views.inc #2081119: Remove Unused local variable $all_labels from /core/modules/taxonomy/taxonomy.views.inc
/core/modules/taxonomy/taxonomy.pages.inc #2081121: Remove Unused local variable $matches from /core/modules/taxonomy/taxonomy.pages.inc
/core/modules/taxonomy/taxonomy.module #2081123: Remove Unused local variable $delta from /core/modules/taxonomy/taxonomy.module
/core/modules/taxonomy/taxonomy.install #2081125: Remove Unused local variable $config from /core/modules/taxonomy/taxonomy.install
/core/modules/taxonomy/lib/Drupal/taxonomy/Plugin/Core/Entity/Vocabulary.php #2081127: Remove Unused local variables from /core/modules/taxonomy/lib/Drupal/taxonomy/Plugin/Core/Entity/Vocabulary.php
/core/modules/taxonomy/lib/Drupal/taxonomy/Tests/VocabularyTest.php #2081129: Remove Unused local variable $key from /core/modules/taxonomy/lib/Drupal/taxonomy/Tests/VocabularyTest.php
/core/includes/pager.inc #2081135: Remove Unused local variable $tags from /core/includes/pager.inc
/core/includes/common.inc #2081139: Remove Unused local variable $options from /core/includes/common.inc Assigned to: beowulf1416
/core/includes/install.core.inc #2081141: Remove Unused local variable $user from /core/includes/install.core.inc
/core/modules/content_translation/lib/Drupal/content_translation/ContentTranslationController.php #2081145: Remove Unused local variable $translations from lib/Drupal/content_translation/ContentTranslationController.php Assigned to: beowulf1416
/core/modules/content_translation/content_translation.pages.inc #2081147: Remove Unused local variable $links from /core/modules/content_translation/content_translation.pages.inc
/core/modules/php/lib/Drupal/php/Plugin/views/argument_default/Php.php #2081157: Remove Unused local variable $view from /core/modules/php/lib/Drupal/php/Plugin/views/argument_default/Php.php
/core/modules/php/lib/Drupal/php/Plugin/views/argument_validator/Php.php #2081159: Remove Unused local variable $view from /core/modules/php/lib/Drupal/php/Plugin/views/argument_validator/Php.php
/modules/navigation_timing/navigation_timing.module #2081161: Remove Unused local variable $group from /modules/navigation_timing/navigation_timing.module
/core/modules/datetime/lib/Drupal/datetime/Tests/DatetimeFieldTest.php #2081165: Remove Unused local variable $date from /core/modules/datetime/lib/Drupal/datetime/Tests/DatetimeFieldTest.php
/core/modules/entity_reference/entity_reference.module #2081181: Remove Unused local variable $bundle_name from /core/modules/entity_reference/entity_reference.module
/core/modules/entity_reference/lib/Drupal/entity_reference/Plugin/field/widget/AutocompleteTagsWidget.php #2081183: Remove Unused local variable $match from /lib/Drupal/entity_reference/Plugin/field/widget/AutocompleteTagsWidget.php
/core/modules/entity_reference/lib/Drupal/entity_reference/Plugin/field/formatter/EntityReferenceFormatterBase.php #2081185: Remove Unused local variable $delta from /lib/Drupal/entity_reference/Plugin/field/formatter/EntityReferenceFormatterBase.php
/core/modules/block/custom_block/lib/Drupal/custom_block/Tests/CustomBlockTranslationUITest.php #2081191: Remove Unused local variable $disabled_custom_block from /lib/Drupal/custom_block/Tests/CustomBlockTranslationUITest.php
/core/modules/taxonomy/lib/Drupal/taxonomy/Plugin/field/formatter/EntityReferenceTaxonomyTermRssFormatter.php #2081195: Remove Unused local variable $delta from taxonomy/Plugin/field/formatter/EntityReferenceTaxonomyTermRssFormatter.php
/core/modules/hal/lib/Drupal/hal/Normalizer/EntityNormalizer.php #2081197: Remove Unused local variable $links from /core/modules/hal/lib/Drupal/hal/Normalizer/EntityNormalizer.php
/core/modules/taxonomy/lib/Drupal/taxonomy/Tests/TaxonomyTermIndentationTest.php #2081199: Remove Unused local variable $term1 from /core/modules/taxonomy/lib/Drupal/taxonomy/Tests/TaxonomyTermIndentationTest.php
/core/modules/file/lib/Drupal/file/Plugin/field/formatter/FileFormatterBase.php #2081203: Remove Unused local variable $delta from /core/modules/file/lib/Drupal/file/Plugin/field/formatter/FileFormatterBase.php
/core/modules/user/lib/Drupal/user/Form/UserPermissionsForm.php #2081205: Remove Unused local variable $rid from /core/modules/user/lib/Drupal/user/Form/UserPermissionsForm.php Assigned to: Nitesh Sethia
/core/modules/block/lib/Drupal/block/Tests/BlockTestBase.php #2081207: Remove obsolete test code from /core/modules/block/lib/Drupal/block/Tests/BlockTestBase.php Assigned to: RunePhilosof
/core/lib/Drupal/Core/EventSubscriber/RedirectResponseSubscriber.php #2081209: Remove Unused local variable $redirect_path from /core/lib/Drupal/Core/EventSubscriber/RedirectResponseSubscriber.php
/core/tests/Drupal/Tests/Component/Image/ImageTest.php #2081211: Remove Unused local variable $test from /core/tests/Drupal/Tests/Component/Image/ImageTest.php
/core/lib/Drupal/Core/Entity/EntityStorageControllerBase.php #2081213: Remove Unused local variable $field_name from /core/lib/Drupal/Core/Entity/EntityStorageControllerBase.php
/core/modules/views/lib/Drupal/views/Plugin/views/area/TokenizeAreaPluginBase.php #2081215: Remove Unused local variable $arg from /core/modules/views/lib/Drupal/views/Plugin/views/area/TokenizeAreaPluginBase.php
/core/modules/aggregator/lib/Drupal/aggregator/Form/OpmlFeedAdd.php #2081219: Remove Unused local variable $data from /core/modules/aggregator/lib/Drupal/aggregator/Form/OpmlFeedAdd.php
/core/modules/views_ui/lib/Drupal/views_ui/Form/Ajax/RearrangeFilter.php #2080035: Remove Unused local variable $name from /core/modules/views_ui/lib/Drupal/views_ui/Form/Ajax/RearrangeFilter.php
/core/modules/views_ui/lib/Drupal/views_ui/Form/Ajax/Rearrange.php #2079891: Remove Unused local variable $name from /core/modules/views_ui/lib/Drupal/views_ui/Form/Ajax/Rearrange.php
/core/modules/node/node.views_execution.inc #2079887: Remove Unused local variable $id from /core/modules/node/node.views_execution.inc
/core/modules/views_ui/lib/Drupal/views_ui/ViewUI.php #2079881: Remove Unused local variable $stack from /core/modules/views_ui/lib/Drupal/views_ui/ViewUI.php
/core/modules/views_ui/lib/Drupal/views_ui/ViewEditFormController.php #2080079: Remove Unused local variable $display_title from /core/modules/views_ui/lib/Drupal/views_ui/ViewEditFormController.php
/modules/testswarm/testswarm.module [#@] Create

From #10 When making an issue, put the number of the new issue between the # and @ and it will make a great link. (the @ shows who it is assigned to, if it is assigned). Remove the create link when putting the issue number in.

Anyone can use the create link to make the issue and then edit this issue summary.

User interface changes

No ui changes.

API changes

No api changes.

Comments

Issue summary:View changes

Updated issue summary.

Issue summary:View changes

init

StatusFileSize
new208.96 KB

Maybe to give an idea, here is what phpstorm tells me: 626 unused variables in our code.

Attached the html output listing files and variables. The xml file has line number.

Issue summary:View changes

noting something.

Doing an issue per file sounds a bit too much, I'd propose at most one issue per folder in core/ (includes, lib, modules/*, tests, etc..). I started with the one for core/includes/* and added it to the issue summary.

StatusFileSize
new358.99 KB

uploading the xml separately, so that ppl don't need to mess with an archive to see what's up.

( edit ) I would agree. We did one issue per file for the same thing in JS and it just takes forever and there are a lot more PHP files. When it's during a sprint it's a bit different though, that could work.

@alexpott asked for these to be one issue per file.
Some of them might need more discussion that are part of settings includes or list().

These are good first issues for new contributors, so while it might seem like a lot of work the pay back will be great.

Issue summary:View changes

Updated issue summary.

Issue summary:View changes

Updated issue summary.

Issue summary:View changes

Updated issue summary.

Issue summary:View changes

Updated issue summary.

Issue summary:View changes

Updated issue summary.

Issue summary:View changes

Updated issue summary.

Issue summary:View changes

Updated issue summary.

Issue summary:View changes

Updated issue summary.

Issue summary:View changes

2002732

Issue summary:View changes

Updated issue summary.

StatusFileSize
new490.22 KB

Is there an issue for unused "use" uses? if not here is the list of the 936 of them.

Beware that list, it includes Annotation classes which many IDEs don't count as being used. Removing them will break everything.

Title:[meta] improve performance by removing unused local variables[meta] improve maintainability by removing unused local variables

Let's not over-egg the performance impact here... each unused variable / line of code will consume memory and cpu time but it's minuscule compared to other factors.

One is very important is that each line of code we have in the codebase needs to be maintained therefore removing cruft is a good thing. It's part of making Drupal a nice place to code... less thinking hmmm... that looks unused... but it is really?

Issue summary:View changes

Update triggered

I need to figure out a way to parse the xml, or get it in a different format. We should expand the table to list more files so the issues can be made.

StatusFileSize
new940 bytes
new264.17 KB

Updated export and php script to generate the table and link to create issues.

Remove all underscore from the files below and it should work.

Issue summary:View changes

moving the hints, as the table grows, people will not see them

Issue summary:View changes

just adding the whole table. need to check if issues already in the summary are there and remove them.

Issue summary:View changes

using [#@] instead of [#} to see who it is assigned to

Issue summary:View changes

Updated issue summary. Added 2 new issues.

Issue summary:View changes

Updated issue summary. Removed stale rows from the second table.

Issue summary:View changes

Updated issue summary for #2056445

Issue summary:View changes

Updated issue summary.

Issue summary:View changes

Updated issue summary.

Issue summary:View changes

modified the listing, specifically concerning /modules/testswarm/testswarm.pages.inc

Issue summary:View changes

added reference to new issue #2057019

Issue summary:View changes

- Created an issue for the removal of variables in /core/modules/user/user.module
- Removed table row for /core/modules/user/user.admin.inc because that file has no unused variables any more.

Issue summary:View changes

created an issue for core/modules/block/block.module

Issue summary:View changes

Moved my issues to the issue table.

@nod_ this is awesome, thanks.

All clear to start knocking some of these out?

Issue summary:View changes

Fixed a copy paste error and added issue for /core/modules/views/views.module

Issue summary:View changes

Updated issue summary.

Issue summary:View changes

Created some issues and altered the tables accordingly

Issue summary:View changes

Created /core/lib/Drupal/Core/Database/ related issues and altered the tables accordingly

Issue summary:View changes

Updated issue summary to include the new created issue.

Issue summary:View changes

Updating issue summary for adding issue https://drupal.org/node/2061387

Issue summary:View changes

Updated issue summary for adding issue https://drupal.org/node/2061397

Issue summary:View changes

Created one sub-issue

Issue summary:View changes

Added new sub-issue

Issue summary:View changes

Added 2 sub-issues

Issue summary:View changes

Added 2 more sub-issues

Issue summary:View changes

Combined 3 lines into one.

Issue summary:View changes

Added 3 more sub-issues

Issue summary:View changes

Added 4 sub-issues.

Issue summary:View changes

Assign /core/lib/Drupal/Core/Routing/RouteProvider.php

Issue summary:View changes

Updated issue summary.

Issue summary:View changes

Updated issue summary.

Issue summary:View changes

Updated issue summary.

Issue summary:View changes

Updated issue summary.

Issue summary:View changes

Updated issue summary.

Issue summary:View changes

Updated issue summary.

Issue summary:View changes

Updated issue summary.

Issue summary:View changes

Added NodeSaveTest issue

Issue summary:View changes

Removed "create" button for nodesavetest issue

Issue summary:View changes

Added issue

Issue summary:View changes

Updated issue summary.

Issue summary:View changes

Updated issue summary.

Issue summary:View changes

Added child issue

Issue summary:View changes

Added child issue

Issue summary:View changes

Added child issue.

Issue summary:View changes

Added child issue.

Issue summary:View changes

Cleaned up the second table by moving active issues to the first one

Issue summary:View changes

Created some issues

Issue summary:View changes

Created some more issues

Issue summary:View changes

Added the #2079857

Issue summary:View changes

Added #2079863

Issue summary:View changes

Added #2079881

Issue summary:View changes

Added #2079887

Issue summary:View changes

Added #2079891

Issue summary:View changes

Updated issue summary.

Issue summary:View changes

Updated issue summary.

Issue summary:View changes

Updated issue summary.

Issue summary:View changes

Updated issue summary.

Issue summary:View changes

Updated issue summary.

Issue summary:View changes

Updated issue summary.

Issue summary:View changes

Updated issue summary.

Issue summary:View changes

Updated issue summary.

Issue summary:View changes

Updated issue summary.

Issue summary:View changes

Updated issue summary.

Issue summary:View changes

Updated issue summary.

Issue summary:View changes

Updated issue summary.

Issue summary:View changes

Updated issue summary.

Issue summary:View changes

Updated issue summary.

Issue summary:View changes

Updated issue summary.

Issue summary:View changes

Updated issue summary.

Issue summary:View changes

Updated issue summary.

Issue summary:View changes

Updated issue summary.

Issue summary:View changes

Updated issue summary.

Issue summary:View changes

Updated issue summary.

Issue summary:View changes

Updated issue summary.

I'm curious about something. Is it possible to write some kind of automated test that will catch these as they're introduced? One would assume PHPStorm is hooking into some kind of PHP Reflection library or similar, but not sure. I am just concerned that we're going through all of this effort that's going to eventually be eroded away without some means of people without PHPStorm ensuring the code base stays sane.

There are some places in core which let's IDEs think that variables are unused even they are not (sadly I don't remember the example).

http://phpmd.org/ seems to be what you want to do.

In an ideal world we would be running phpmd as part of testbot. But it is going to take a while to get there.

Issue summary:View changes

Updated issue summary.

Issue summary:View changes

added info about how to move on to other types of issues.

Wondering how to find other issues to work on?

These issues are nice ones for people to learn the core process. (After doing a few, and reviewing a few, find other issues in other topics by looking for other novice issues: https://drupal.org/project/issues/search/drupal?status%5B%5D=Open&versio... or other metas. See irc factoid: metas? Which links to the methods meta #2016679: [Meta] Expand Entity Type interfaces to provide methods and properties rename meta #2052421: [META] Rename Views properties to core standards Another option is to jump in #drupal-contribute and ask for someone to recommend an issue to work on, or attend core mentoring office hours to find issues matched to your interest and skills.)

(updated issue summary)

Issue summary:View changes

added html ending tag

Issue summary:View changes

updated remaining tasks.

We should find better way to work on this kind of patches.

From IRC:

tell andypost the unused variable patches are also creating a testbot backlog. I think it's fine to teach someone how to create a patch for the very first time with those patches, but after that I feel they'r creating more overhead than the value we get out of them. Is there any way to graduate contributors from the unused variables to a remotely useful patch once they've got their first commit?

Some guidance for directing people to other issues has been added... maybe some more, like 3 of these a day please? Along with the "how to find other issues" would alleviate some of the testbot strain.

The bot is back to 0 queued now. Did @jthorson end up spinning up the extra 20 testbots to clear it?

Hm. If we use this in Prague on the Get Involved Day... we will run into the same issue. Even if we have 50 people only do one of these a piece. Well no matter what people work on actually. It's just that they could do one of these *and* another issue during the day. I'd better talk to @jthorson.

it's my wrong when create many issues in yesterday. I think we need combine many issue for one patch.

Issue summary:View changes

small grammar fix

Issue summary:View changes

added more hints and examples for reviewers.

Issue summary:View changes

uh, i can write html. fixing.

Issue summary:View changes

more html fix

Issue summary:View changes

added hint about checking if it applies and reroll.

Issue summary:View changes

another hint to say what was checked.

Issue summary:View changes

Updated issue summary.

Issue summary:View changes

Updated issue summary.

Issue summary:View changes

Changed link to the issue with tokens

Issue summary:View changes

Issue summary:View changes

Cleaning up sub-tasks.

Cleaning up sub-tasks.

Issue summary:View changes

More update to sub-tasks

As much as I love initiatives like this to help get new people involved in core, these issues are definitely taking their toll. Over 50 of the 158 RTBC issues coming back from Thanksgiving were these issues. So tonight I literally spent 4 5 hours (and counting) doing just about nothing else but reviewing/committing/needs working these. That's 4 5 hours I didn't spend reviewing major/critical issues that help push D8 further towards release. :( And I only get about one of these 4 5-hour uninterrupted chunks per week.

This work is very valuable; a few of these have managed to catch some real actual bugs. But is it possible maybe to start combine some of these patches into bigger, less granular ones (per-file is just a bit nuts) so that the needs review/needs work/needs review/RTBC/commit cycle is more justified?

Please change the structure of this so that patches are rolled at a minimum on a per-module basis. Per file is unnecessarily granular.

Also, if you have already done 2 or 3 of these tasks, please leave the remainder for others to complete.

Also, please file all the sub-tasks as minor so that they can be sorted from normal issues.

Issue summary:View changes

Moved the fixed rows down so we can see what issues are still listed.

Issue summary:View changes

I reopened a couple that had actual bugs associated with them and retitled them to reflect their actual scope. When you discover a bug in the process of rolling a patch to remove several from a module, it makes sense to spin off a normal, targeted bug report. Thanks everyone!

Tagging.

Issue summary:View changes

Issue summary:View changes

Issue summary:View changes

updating a bit of what issue is doing what.

Issue summary:View changes

updating a bit of what issue is doing what.

Issue summary:View changes

updating what core/tests is covering

Issue summary:View changes

updating what core/tests is covering

Would be great to get this reviewed before I need to reroll again: #2080343: Remove Unused local variables from system module

Would be great to get this reviewed before I need to reroll again: #2080343: Remove Unused local variables from system module