Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.See meta #2002650: [meta, no patch] improve maintainability by removing unused local variables
core/includes/module.inc
- Unused local variable $schema_store (289)
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | Drupal_core-removed-unused-local-variable-2002728-1.patch | 530 bytes | louisjimenez |
Comments
Comment #1
louisjimenez CreditAttribution: louisjimenez commentedPatch attached
Comment #3
kerasai CreditAttribution: kerasai commented#1: Drupal_core-removed-unused-local-variable-2002728-1.patch queued for re-testing.
Comment #4
kerasai CreditAttribution: kerasai commentedLooks good. Nothing tricky and the testbot is happy.
Comment #5
louisjimenez CreditAttribution: louisjimenez commentedThanks for reviewing!
Comment #6
alexpottNeeds a reroll as this code has been refactored to
Drupal\Core\Extension\ModuleHandlerComment #7
kerasai CreditAttribution: kerasai commented#1: Drupal_core-removed-unused-local-variable-2002728-1.patch queued for re-testing.
Comment #9
martin107 CreditAttribution: martin107 commentedThis patch has become irrelevant and the issue should be marked complete/invalid.
Results from searching the code base:-
1) module.inc has been removed/renamed.
2) there is only one definition of function module_enable() -- bears no relation to function referred to in the patch.
3) patch removes a single line $schema_store = Drupal::keyValue('system.schema');
searching code base for this line -- shows one occurrence in which the variable is used later in function.
Comment #10
martin107 CreditAttribution: martin107 commentedChanged status after conversation with Cottser