Files: 
CommentFileSizeAuthor
#8 drupal-viewsRename-instantiate_view-2002872-7.patch1.64 KBheddn
PASSED: [[SimpleTest]]: [MySQL] 57,634 pass(es).
[ View ]
#7 drupal-viewsRename-page_display_options-2003436-14.patch4.56 KBheddn
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch drupal-viewsRename-page_display_options-2003436-14_0.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
#2 views-rename-compile_fields-2002428-2.patch866 byteshansenm
PASSED: [[SimpleTest]]: [MySQL] 58,075 pass(es).
[ View ]

Comments

Assigned:Unassigned» hansenm

I'm working on this at the DrupalCon Portland sprint.

Status:Active» Needs review
StatusFileSize
new866 bytes
PASSED: [[SimpleTest]]: [MySQL] 58,075 pass(es).
[ View ]

Status:Needs review» Needs work

The last submitted patch, views-rename-compile_fields-2002428-2.patch, failed testing.

Tests failing. Please investigate and re-roll a patch.

Status:Needs work» Needs review

Status:Needs review» Needs work

Access modifier needs to be added to the function line as mentioned in the meta issue discussion:
http://drupal.org/node/1856630#comment-7451652

Should be "public function ..."

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/query/Sql.phpundefined
@@ -1189,7 +1189,7 @@ function get_non_aggregates() {
-  function compile_fields($query) {
+ public function compileFields($query) {

Status:Needs work» Needs review
StatusFileSize
new4.56 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch drupal-viewsRename-page_display_options-2003436-14_0.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Actually, protected seems more appropriate ($this->instantiateView) is the only call. Let's see if it keeps the testbot happy.

StatusFileSize
new1.64 KB
PASSED: [[SimpleTest]]: [MySQL] 57,634 pass(es).
[ View ]

Let's try the right patch.

Status:Needs review» Reviewed & tested by the community

#8 looks good to me. All instances of the instantiate_view() method have been renamed. instantiateView() has been given protected visibility.

I think that #2 was mistakenly posted to the wrong issue. It should have gone into #2002428: Rename Views method compile_fields() to compileFields().

Status:Reviewed & tested by the community» Fixed

Committed 7790f21 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.