Support from Acquia helps fund testing for Drupal Acquia logo

Comments

aspilicious’s picture

Assigned: Unassigned » aspilicious

Lets go!

aspilicious’s picture

Status: Active » Needs review
FileSize
1.89 KB

Done?

aspilicious’s picture

oenie’s picture

Status: Needs review » Needs work
+++ b/core/modules/views/lib/Drupal/views/Plugin/views/pager/PagerPluginBase.phpundefined
@@ -249,7 +249,7 @@ function uses_exposed() {
+  public function itemsPerPageExposed() {

This can be set to protected instead of public.

aspilicious’s picture

Status: Needs work » Needs review
FileSize
1.91 KB

Status: Needs review » Needs work
Issue tags: -Novice, -VDC

The last submitted patch, 2002882-items-per-page-exposed-5.patch, failed testing.

aspilicious’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 2002882-items-per-page-exposed-5.patch, failed testing.

aspilicious’s picture

Status: Needs work » Needs review
Issue tags: +Novice, +VDC
oenie’s picture

Status: Needs review » Reviewed & tested by the community

Looks good to me !

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed fb39ef6 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.