Files: 
CommentFileSizeAuthor
#7 views.core-change_get_aggregation_info-2002892-06.patch5.28 KBtvlooy
PASSED: [[SimpleTest]]: [MySQL] 55,928 pass(es).
[ View ]
#6 views-rename_get_aggregation_info-2002892-6.patch5.28 KBJeroenT
PASSED: [[SimpleTest]]: [MySQL] 57,247 pass(es).
[ View ]
#2 views.core-change_get_aggregation_info-2002892-02.patch4.52 KBtoddtomlinson
PASSED: [[SimpleTest]]: [MySQL] 55,663 pass(es).
[ View ]

Comments

Assigned:Unassigned» toddtomlinson

Assigned:toddtomlinson» Unassigned
Status:Active» Needs review
StatusFileSize
new4.52 KB
PASSED: [[SimpleTest]]: [MySQL] 55,663 pass(es).
[ View ]

Patch attached to change get_aggregation_info to getAggregationInfo.

Status:Needs review» Needs work
Issue tags:-Novice, -VDC

The last submitted patch, views.core-change_get_aggregation_info-2002892-02.patch, failed testing.

Status:Needs work» Needs review
Issue tags:+Novice, +VDC

Status:Needs review» Needs work

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/query/QueryPluginBase.phpundefined
@@ -86,7 +86,7 @@ function add_signature(ViewExecutable $view) { }
+  function getAggregationInfo() { }
+++ b/core/modules/views/lib/Drupal/views/Plugin/views/query/Sql.phpundefined
@@ -1647,7 +1647,7 @@ function add_signature(ViewExecutable $view) {
+  function getAggregationInfo() {

Add public access modifier in front of the functions to adher to the new OOP standards.

core/modules/views_ui/lib/Drupal/views_ui/Form/Ajax/ConfigItem.php, line 220:

$aggregate = $executable->query->get_aggregation_info();

And it seems you forgot a reference to the method in a different module.

Status:Needs work» Needs review
StatusFileSize
new5.28 KB
PASSED: [[SimpleTest]]: [MySQL] 57,247 pass(es).
[ View ]

Patch attached to change get_aggregation_info to getAggregationInfo.

StatusFileSize
new5.28 KB
PASSED: [[SimpleTest]]: [MySQL] 55,928 pass(es).
[ View ]

Duplicate patch. Sorry!

Looks fine to me now ! Once the patch passed testbot, it's RTBC for me.

Status:Needs review» Reviewed & tested by the community

No mentions of get_aggregation_info any more and applies cleanly. Passed testbot.

No mentions of get_aggregation_info and applies cleanly. Passed testbot.

Status:Reviewed & tested by the community» Fixed

Committed b06ef6d and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.