Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards
Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards
Comments
Comment #1
seantwalshWorking on this as part of the Portland2013 getting involved with core sprint.
Comment #2
seantwalshReplaced 11 instances of get_argument with getArgument.
Comment #3
oenie CreditAttribution: oenie commentedAdd public access modifier in front of the functions to adher to the new OOP standards.
Comment #4
seantwalshWorking on adding access modifier.
Comment #5
seantwalshAdded public access modifier. Thanks oenie!
Comment #6
oenie CreditAttribution: oenie commentedPatch looks ok to me now! If it passed the testbot review, it's RTBC.
Comment #7
oenie CreditAttribution: oenie commentedUnfortunately we need a reroll, the patch doesn't apply anymore.
Comment #8
seantwalshRerolled!
Comment #9
dawehnerWrong indentation.
If we adapt it then properly: This should be @inheritdoc
Comment #10
dawehnerComment #11
seantwalshSorry about that, fixed indentation and updated with {@inheritdoc}.
Comment #12
dawehnerNice!
Comment #13
alexpottNeeds a reroll
Comment #14
jibranReroll
Comment #15
dawehnerGreat!
Comment #16
alexpottCommitted f1ba409 and pushed to 8.x. Thanks!