Support from Acquia helps fund testing for Drupal Acquia logo

Comments

seantwalsh’s picture

Assigned: Unassigned » seantwalsh

Working on this as part of the Portland2013 getting involved with core sprint.

seantwalsh’s picture

Status: Active » Needs review
FileSize
6.48 KB

Replaced 11 instances of get_argument with getArgument.

oenie’s picture

Status: Needs review » Needs work
+++ b/core/modules/node/lib/Drupal/node/Plugin/views/argument_default/Node.phpundefined
@@ -24,7 +24,7 @@
+  function getArgument() {

+++ b/core/modules/taxonomy/lib/Drupal/taxonomy/Plugin/views/argument_default/Tid.phpundefined
@@ -117,7 +117,7 @@ public function submitOptionsForm(&$form, &$form_state, &$options = array()) {
+  function getArgument() {

+++ b/core/modules/user/lib/Drupal/user/Plugin/views/argument_default/CurrentUser.phpundefined
@@ -24,7 +24,7 @@
+  function getArgument() {

+++ b/core/modules/user/lib/Drupal/user/Plugin/views/argument_default/User.phpundefined
@@ -37,7 +37,7 @@ public function buildOptionsForm(&$form, &$form_state) {
+  function getArgument() {

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/argument_default/ArgumentDefaultPluginBase.phpundefined
@@ -34,7 +34,7 @@
+  function getArgument() { }

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/argument_default/Fixed.phpundefined
@@ -41,7 +41,7 @@ public function buildOptionsForm(&$form, &$form_state) {
+  function getArgument() {

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/argument_default/Php.phpundefined
@@ -50,7 +50,7 @@ public function access() {
+  function getArgument() {

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/argument_default/Raw.phpundefined
@@ -49,7 +49,7 @@ public function buildOptionsForm(&$form, &$form_state) {
+  function getArgument() {

+++ b/core/modules/views/tests/views_test_data/lib/Drupal/views_test_data/Plugin/views/argument_default/ArgumentDefaultTest.phpundefined
@@ -32,9 +32,9 @@ protected function defineOptions() {
+  public function getArgument() {

Add public access modifier in front of the functions to adher to the new OOP standards.

seantwalsh’s picture

Working on adding access modifier.

seantwalsh’s picture

Status: Needs work » Needs review
FileSize
6.54 KB

Added public access modifier. Thanks oenie!

oenie’s picture

Patch looks ok to me now! If it passed the testbot review, it's RTBC.

oenie’s picture

Status: Needs review » Needs work

Unfortunately we need a reroll, the patch doesn't apply anymore.

seantwalsh’s picture

Status: Needs work » Needs review
FileSize
6.54 KB

Rerolled!

dawehner’s picture

+++ b/core/modules/node/lib/Drupal/node/Plugin/views/argument_default/Node.phpundefined
@@ -24,7 +24,7 @@
+ public function getArgument() {

Wrong indentation.

+++ b/core/modules/views/tests/views_test_data/lib/Drupal/views_test_data/Plugin/views/argument_default/ArgumentDefaultTest.phpundefined
@@ -32,9 +32,9 @@ protected function defineOptions() {
+   * Overrides Drupal\views\Plugin\views\argument_default\ArgumentDefaultPluginBase::getArgument().

If we adapt it then properly: This should be @inheritdoc

dawehner’s picture

Status: Needs review » Needs work
seantwalsh’s picture

Status: Needs work » Needs review
FileSize
6.46 KB

Sorry about that, fixed indentation and updated with {@inheritdoc}.

dawehner’s picture

Status: Needs review » Reviewed & tested by the community

Nice!

alexpott’s picture

Status: Reviewed & tested by the community » Needs work

Needs a reroll

curl https://drupal.org/files/core-rename_get_argument_TO_getArgument-2002894-11.patch | git a
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  6612  100  6612    0     0   7041      0 --:--:-- --:--:-- --:--:--  8609
error: patch failed: core/modules/views/lib/Drupal/views/Plugin/views/argument/ArgumentPluginBase.php:744
error: core/modules/views/lib/Drupal/views/Plugin/views/argument/ArgumentPluginBase.php: patch does not apply
jibran’s picture

Status: Needs work » Needs review
FileSize
6.46 KB

Reroll

dawehner’s picture

Status: Needs review » Reviewed & tested by the community

Great!

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed f1ba409 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.