Files: 
CommentFileSizeAuthor
#6 drupal-viewsRename-get_channel_elements-2002896-6.patch1.42 KBheddn
PASSED: [[SimpleTest]]: [MySQL] 57,799 pass(es).
[ View ]
#2 2002896.patch1011 byteshoZt
FAILED: [[SimpleTest]]: [MySQL] 55,902 pass(es), 1 fail(s), and 0 exception(s).
[ View ]

Comments

Assigned:Unassigned» hoZt

Status:Active» Needs review
StatusFileSize
new1011 bytes
FAILED: [[SimpleTest]]: [MySQL] 55,902 pass(es), 1 fail(s), and 0 exception(s).
[ View ]

Status:Needs review» Reviewed & tested by the community

reviewed the name changes, looks good.

Status:Reviewed & tested by the community» Needs work

The last submitted patch, 2002896.patch, failed testing.

This feels really like a protected method.

StatusFileSize
new1.42 KB
PASSED: [[SimpleTest]]: [MySQL] 57,799 pass(es).
[ View ]

Added protected.

Status:Needs work» Needs review

Status:Needs review» Needs work
Issue tags:-Novice, -VDC

The last submitted patch, drupal-viewsRename-get_channel_elements-2002896-6.patch, failed testing.

Status:Needs work» Needs review
Issue tags:+Novice, +VDC

#6: drupal-viewsRename-get_channel_elements-2002896-6.patch queued for re-testing.

I ran some of the failed tests locally and they passed so I'm re-queued for the testbot

Status:Needs review» Reviewed & tested by the community

Perfect! I think this will maybe dissappear in the future, but yeah let's not think about this possibility for now.

Status:Reviewed & tested by the community» Fixed

Committed 281e533 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.