Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards
Comment | File | Size | Author |
---|---|---|---|
#18 | 2002898_rename-views-method-get_current_page_18.patch | 4.16 KB | somepal |
#16 | 2002898_rename-views-method-get_current_page_16.patch | 4.15 KB | somepal |
#12 | 2002898-get_current_page-conversion_12.patch | 6.41 KB | rootwork |
#12 | interdiff.txt | 6.56 KB | rootwork |
#4 | 2002898-get_current_page-conversion_4.patch | 2.79 KB | kevin.reiss |
Comments
Comment #1
Psikik CreditAttribution: Psikik commentedComment #2
Psikik CreditAttribution: Psikik commentedConverts the get_current_page() function to getCurrentPage and adds the public decorator.
Comment #3
Psikik CreditAttribution: Psikik commentedComment #4
kevin.reiss CreditAttribution: kevin.reiss commentedAdding public keyword to method.
Comment #5
shoptalk CreditAttribution: shoptalk commentedLooks good
Comment #7
rootwork#4: 2002898-get_current_page-conversion_4.patch queued for re-testing.
Comment #9
rootwork#4: 2002898-get_current_page-conversion_4.patch queued for re-testing.
Comment #11
rootworkworking on this
Comment #12
rootworkOK, so I'm pretty sure the patch in #4 is failing because while getCurrentPage was set correctly, the relevant test is also relying on setCurrentPage, which was only partially renamed. The related issue is #2003292: Rename Views method set_current_page() to setCurrentPage().
So just for the purposes of seeing if this will pass the test, I've changed all the references to setCurrentPage as well. I'm attaching an interdiff. If this passes, then #4 will likely pass once #2003292: Rename Views method set_current_page() to setCurrentPage() lands (although conversely that might fail until this one lands).
Comment #13
heddnNeeds a re-roll. Instructions for "re-rolling" a new patch that applies cleanly.
$ git apply --index 2002898-get_current_page-conversion_12.patch
error: patch failed: core/modules/views/lib/Drupal/views/Plugin/views/field/Counter.php:50
error: core/modules/views/lib/Drupal/views/Plugin/views/field/Counter.php: patch does not apply
error: patch failed: core/modules/views/lib/Drupal/views/ViewExecutable.php:753
error: core/modules/views/lib/Drupal/views/ViewExecutable.php: patch does not apply
Comment #14
aspilicious CreditAttribution: aspilicious commentedComment #15
somepal CreditAttribution: somepal commentedI am taking this.
Comment #16
somepal CreditAttribution: somepal commentedI might need to change the setter as well, but want to try this.
Comment #17
dawehnerThank you. Yeah please not do both at the same time.
Should be a public method.
Comment #18
somepal CreditAttribution: somepal commentedyeah, sorry I missed that. here's the re-roll, made it public.
Comment #19
dawehnerThank you very much!
Comment #20
webchickCommitted and pushed to 8.x. Thanks!
Moving to the Views queue for the change notice.
Comment #21
xjmWe'll create a single change notice in #1856630: [Change notice] [META] Rename Views methods to core standards.