Files: 
CommentFileSizeAuthor
#21 drupal-viewsRename-get_field-2002910-21.patch15.05 KBheddn
PASSED: [[SimpleTest]]: [MySQL] 57,190 pass(es).
[ View ]
#18 Rename-Views-method-get_field-to-getField-2002910-18.patch19.37 KBdiarmy
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch Rename-Views-method-get_field-to-getField-2002910-18.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
#18 interdiff.txt4.61 KBdiarmy
#14 Rename-Views-method-get_field-to-getField-2002910-14.patch13.36 KBdiarmy
PASSED: [[SimpleTest]]: [MySQL] 55,827 pass(es).
[ View ]
#14 interdiff.txt3.82 KBdiarmy
#12 Rename-Views-method-get_field-to-getField-2002910-12.patch9.54 KBdiarmy
FAILED: [[SimpleTest]]: [MySQL] 55,877 pass(es), 1 fail(s), and 0 exception(s).
[ View ]
#12 interdiff.txt683 bytesdiarmy
#3 Rename-Views-method-get_field-to-getField-2002910-1.patch14.08 KBdbcollies
PASSED: [[SimpleTest]]: [MySQL] 55,685 pass(es).
[ View ]
#2 views.core-replace_get_file_with_getfile-2002910-02.patch10.32 KBtoddtomlinson
FAILED: [[SimpleTest]]: [MySQL] 55,700 pass(es), 2 fail(s), and 0 exception(s).
[ View ]

Comments

Assigned:Unassigned» toddtomlinson

Status:Active» Needs review
StatusFileSize
new10.32 KB
FAILED: [[SimpleTest]]: [MySQL] 55,700 pass(es), 2 fail(s), and 0 exception(s).
[ View ]

Replaced get_file with getFile across several views.core files. Patch attached.

StatusFileSize
new14.08 KB
PASSED: [[SimpleTest]]: [MySQL] 55,685 pass(es).
[ View ]

Status:Needs review» Needs work

The last submitted patch, Rename-Views-method-get_field-to-getField-2002910-1.patch, failed testing.

I believe there to be a bug in the test, not in the code submitted in comment #3. The test fails randomly, with no change in the code

Status:Needs work» Needs review

I think the patch in comment #2 (and I apologize that I didn't notice you had taken this task before I made my patch) is missing changes to the following two files:

  • core/modules/contextual/lib/Drupal/contextual/Plugin/views/field/ContextualLinks.php
  • core/modules/field/lib/Drupal/field/Tests/Views/HandlerFieldFieldTest.php

I suspect the second one is what's causing the failure in HandlerFieldFieldTest. I'm convinced that it's something outside of either of these patches that's causing the BlockRenderOrderTest random failure

Status:Needs review» Needs work

The last submitted patch, Rename-Views-method-get_field-to-getField-2002910-1.patch, failed testing.

Status:Needs work» Needs review
Issue tags:+Novice, +VDC

Status:Needs review» Needs work

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/row/RssFields.phpundefined
@@ -187,15 +187,15 @@ function render($row) {
+  function getField($index, $field_id) {

Add public access modifier in front of the function to adher to the new OOP standards.

Status:Needs work» Needs review
StatusFileSize
new683 bytes
new9.54 KB
FAILED: [[SimpleTest]]: [MySQL] 55,877 pass(es), 1 fail(s), and 0 exception(s).
[ View ]

Added public access modifier to getField function in RssFields class as recommended in #11

Status:Needs review» Needs work

The last submitted patch, Rename-Views-method-get_field-to-getField-2002910-12.patch, failed testing.

StatusFileSize
new3.82 KB
new13.36 KB
PASSED: [[SimpleTest]]: [MySQL] 55,827 pass(es).
[ View ]

Updated instances of get_field() in HandlerFieldFieldTest.

Status:Needs work» Needs review

Updating status to needs review.

Status:Needs review» Reviewed & tested by the community

Looks good to me now !

Status:Reviewed & tested by the community» Needs work

Seems like we've added a new one in Drupal\contextual\Plugin\views\field\ContextualLinks

$rendered_field = $this->view->style_plugin->get_field($this->view->row_index, $field);

StatusFileSize
new4.61 KB
new19.37 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch Rename-Views-method-get_field-to-getField-2002910-18.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Replaced more instances of get_field() with getField()

Status:Needs work» Needs review

Status:Needs review» Needs work

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/argument/ArgumentPluginBase.phpundefined
@@ -740,7 +740,7 @@ function hasDefaultArgument() {
-  function get_default_argument() {
+  public function getDefaultArgument() {
@@ -1014,7 +1014,7 @@ function get_value() {
-      $arg = $argument->get_default_argument();
+      $arg = $argument->getDefaultArgument();
+++ b/core/modules/views/lib/Drupal/views/Plugin/views/argument/Date.phpundefined
@@ -57,7 +57,7 @@ public function defaultArgumentForm(&$form, &$form_state) {
-  function get_default_argument($raw = FALSE) {
+  public function getDefaultArgument($raw = FALSE) {

Out of scope for this issue.

StatusFileSize
new15.05 KB
PASSED: [[SimpleTest]]: [MySQL] 57,190 pass(es).
[ View ]

Let's see if this makes the testbot happy.

Status:Needs work» Needs review

Status:Needs review» Reviewed & tested by the community

Awesome!

Looks good to me !

Status:Reviewed & tested by the community» Fixed

Committed b48343a and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.