Files: 
CommentFileSizeAuthor
#7 2002916-rename-get_formula.patch4.73 KBsillygwailo
PASSED: [[SimpleTest]]: [MySQL] 55,823 pass(es).
[ View ]
#2 2002916-rename-get_formula.patch4.71 KBsillygwailo
FAILED: [[SimpleTest]]: [MySQL] 55,733 pass(es), 1 fail(s), and 0 exception(s).
[ View ]

Comments

Assigned:Unassigned» sillygwailo

baldwinlouie and I are taking this.

Status:Active» Needs review
StatusFileSize
new4.71 KB
FAILED: [[SimpleTest]]: [MySQL] 55,733 pass(es), 1 fail(s), and 0 exception(s).
[ View ]

Here's a patch.

Status:Needs review» Needs work
Issue tags:-Novice, -VDC

The last submitted patch, 2002916-rename-get_formula.patch, failed testing.

Status:Needs work» Needs review

#2: 2002916-rename-get_formula.patch queued for re-testing.

Status:Needs review» Needs work
Issue tags:+Novice, +VDC

The last submitted patch, 2002916-rename-get_formula.patch, failed testing.

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/argument/Date.phpundefined
@@ -92,11 +92,11 @@ function get_sort_name() {
+  function getFormula() {
+++ b/core/modules/views/lib/Drupal/views/Plugin/views/argument/Formula.phpundefined
@@ -38,7 +38,7 @@ public function init(ViewExecutable $view, DisplayPluginBase $display, array &$o
+  function getFormula() {
+++ b/core/modules/views/lib/Drupal/views/Plugin/views/argument/String.phpundefined
@@ -175,7 +175,7 @@ function summary_query() {
+  function getFormula() {

Add public access modifier in front of the functions to adher to the new OOP standards.

Status:Needs work» Needs review
StatusFileSize
new4.73 KB
PASSED: [[SimpleTest]]: [MySQL] 55,823 pass(es).
[ View ]

Re-rolled with public.

Status:Needs review» Reviewed & tested by the community

Looks good to me now !

Status:Reviewed & tested by the community» Fixed

Committed 16c85ce and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.