Files: 
CommentFileSizeAuthor
#26 vdc-2002918-26.patch1.3 KBtim.plunkett
PASSED: [[SimpleTest]]: [MySQL] 58,243 pass(es).
[ View ]
#23 2002918-rename-get_items.patch2.04 KBsillygwailo
PASSED: [[SimpleTest]]: [MySQL] 56,831 pass(es).
[ View ]
#21 2002918-rename-get_items.patch2.03 KBsillygwailo
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 2002918-rename-get_items_1.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
#18 2002918-18.patch2.03 KBjibran
PASSED: [[SimpleTest]]: [MySQL] 56,301 pass(es).
[ View ]
#12 2002918-rename-get_items.patch2.03 KBsillygwailo
PASSED: [[SimpleTest]]: [MySQL] 57,596 pass(es).
[ View ]
#8 2002918-rename-get_items-3.patch2.03 KBoenie
PASSED: [[SimpleTest]]: [MySQL] 55,815 pass(es).
[ View ]
#6 core-rename-views-method-get-items-2002918-7.patch606 byteskronda
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git].
[ View ]
#2 2002918-rename-get_items.patch2.01 KBsillygwailo
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git].
[ View ]

Comments

Assigned:Unassigned» sillygwailo

baldwinlouie and I are taking this one.

StatusFileSize
new2.01 KB
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git].
[ View ]

Here's a patch.

Status:Active» Needs review

Status:Needs review» Needs work

The last submitted patch, 2002918-rename-get_items.patch, failed testing.

Assigned:sillygwailo» kronda

Going to re-roll.

Assigned:kronda» Unassigned
Status:Needs work» Needs review
StatusFileSize
new606 bytes
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git].
[ View ]

I rolled a new patch and added the public keyword to the function, per the feedback on this issue: http://drupal.org/node/2002460

Status:Needs review» Needs work

The last submitted patch, core-rename-views-method-get-items-2002918-7.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new2.03 KB
PASSED: [[SimpleTest]]: [MySQL] 55,815 pass(es).
[ View ]

To avoid confusion over the previous patches, i'm rerolling patch #2 with corrections on the acces modifiers for the changed functions.

Assigned:Unassigned» oenie

Status:Needs review» Needs work

Needs a re-roll.

$ git apply 2002918-rename-get_items-3.patch
error: patch failed: core/modules/views/lib/Drupal/views/Plugin/views/field/FieldPluginBase.php:1110
error: core/modules/views/lib/Drupal/views/Plugin/views/field/FieldPluginBase.php: patch does not apply

Status:Needs work» Needs review

Re-rolled against 8.x. Might need another re-roll when the advanced_render() change is committed.

StatusFileSize
new2.03 KB
PASSED: [[SimpleTest]]: [MySQL] 57,596 pass(es).
[ View ]

Patch attached.

Status:Needs review» Needs work
Issue tags:-Novice, -VDC

The last submitted patch, 2002918-rename-get_items.patch, failed testing.

Status:Needs work» Needs review
Issue tags:+Novice, +VDC

#12: 2002918-rename-get_items.patch queued for re-testing.

Status:Needs review» Reviewed & tested by the community

:D thnx!

reviewed and checked all the calls. gtg with #12 2002918-rename-get_items.patch

Status:Reviewed & tested by the community» Needs work

Needs a reroll

curl https://drupal.org/files/2002918-rename-get_items_0.patch | git a
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  2079  100  2079    0     0   2791      0 --:--:-- --:--:-- --:--:--  3640
error: patch failed: core/modules/views/lib/Drupal/views/Plugin/views/field/FieldPluginBase.php:1106
error: core/modules/views/lib/Drupal/views/Plugin/views/field/FieldPluginBase.php: patch does not apply
error: patch failed: core/modules/views/lib/Drupal/views/Plugin/views/field/PrerenderList.php:99
error: core/modules/views/lib/Drupal/views/Plugin/views/field/PrerenderList.php: patch does not apply

Status:Needs work» Needs review
StatusFileSize
new2.03 KB
PASSED: [[SimpleTest]]: [MySQL] 56,301 pass(es).
[ View ]

Re-roll
Conflict

++<<<<<<< HEAD
+  function get_items($values) {
+    $field = $this->getValue($values);
++=======
+   protected function getItems($values) {
+     $field = $this->get_value($values);
++>>>>>>> 12

Resolved
-   function get_items($values) {
-  protected function getItems($values) {
-    $field = $this->get_value($values);
++  function getItems($values) {
+    $field = $this->getValue($values);

protected function getItems($values) {

Assigned:oenie» Unassigned

StatusFileSize
new2.03 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 2002918-rename-get_items_1.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Re-rolled with protected in the PrerenderList.php.

Status:Needs review» Needs work

The last submitted patch, 2002918-rename-get_items.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new2.04 KB
PASSED: [[SimpleTest]]: [MySQL] 56,831 pass(es).
[ View ]

Re-roll.

Status:Needs review» Reviewed & tested by the community

Perfect

Status:Reviewed & tested by the community» Fixed

Committed ac6bbe4 and pushed to 8.x. Thanks!

Status:Fixed» Needs review
StatusFileSize
new1.3 KB
PASSED: [[SimpleTest]]: [MySQL] 58,243 pass(es).
[ View ]

I started porting FullCalendar to D8, and this bit me hard.
I remember adding this method to D7 so contrib could use it.

It very much needs to be public.

Status:Needs review» Reviewed & tested by the community

Status:Reviewed & tested by the community» Fixed

Committed a24345a and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.