Files: 
CommentFileSizeAuthor
#6 drupal-rename-use_string_group_by-views-2002946-6.patch1.8 KBmari3.14
PASSED: [[SimpleTest]]: [MySQL] 55,712 pass(es).
[ View ]
#5 drupal-rename-use_string_group_by-views-2002946-5.patch1.41 KBmari3.14
PASSED: [[SimpleTest]]: [MySQL] 55,780 pass(es).
[ View ]
#2 drupal-rename-use_string_group_by-2002946-2.patch1.78 KBmalcomio
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch drupal-rename-use_string_group_by-2002946-2.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Comments

Assigned:Unassigned» malcomio

Status:Active» Needs review
StatusFileSize
new1.78 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch drupal-rename-use_string_group_by-2002946-2.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Status:Needs review» Needs work

The last submitted patch, drupal-rename-use_string_group_by-2002946-2.patch, failed testing.

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/field/FieldPluginBase.phpundefined
@@ -402,7 +402,7 @@ function get_value($values, $field = NULL) {
+  function useStringGroupBy() {

Should be "public function useString..."

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/field/FieldPluginBase.phpundefined
@@ -402,7 +402,7 @@ function get_value($values, $field = NULL) {
\ No newline at end of file

A file always need to end with a newline

Status:Needs work» Needs review
StatusFileSize
new1.41 KB
PASSED: [[SimpleTest]]: [MySQL] 55,780 pass(es).
[ View ]

StatusFileSize
new1.8 KB
PASSED: [[SimpleTest]]: [MySQL] 55,712 pass(es).
[ View ]

Patch on #5 is incomplete, please see here a new patch with all the changes necessary.

Title:Rename Views method use_string_group_by() to useStringGroupBy()Rename Views method lgtm() to useStringGroupBy()
Status:Needs review» Reviewed & tested by the community

Looks good to me now !

Status:Reviewed & tested by the community» Fixed

Committed 89f15d2 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.