Files: 
CommentFileSizeAuthor
#10 view-rename_method-2002974-10.patch6.18 KBdanylevskyi
PASSED: [[SimpleTest]]: [MySQL] 56,068 pass(es).
[ View ]
#7 VDC-Rename_render_text-2003328-5.patch2.4 KBtvlooy
PASSED: [[SimpleTest]]: [MySQL] 57,334 pass(es).
[ View ]
#5 drupal-rename-title-query-2002974-5.patch6.18 KBtvlooy
PASSED: [[SimpleTest]]: [MySQL] 57,247 pass(es).
[ View ]
#2 drupal-rename-title-query-2002974-2.patch6.11 KBkenianbei
PASSED: [[SimpleTest]]: [MySQL] 55,913 pass(es).
[ View ]

Comments

Assigned:Unassigned» kenianbei

Status:Active» Needs review
StatusFileSize
new6.11 KB
PASSED: [[SimpleTest]]: [MySQL] 55,913 pass(es).
[ View ]

Status:Needs review» Needs work

You need to add the access modifier (public/private/protected) before the function name. Take a look at the parent issue (http://drupal.org/node/1856630), comments #28, #34, #35 for more details.

You can see an example patch here: http://drupal.org/node/2001672

Assigned:kenianbei» tvlooy

Work in progress

StatusFileSize
new6.18 KB
PASSED: [[SimpleTest]]: [MySQL] 57,247 pass(es).
[ View ]

Added the access modifiers.

Assigned:tvlooy» Unassigned
Status:Needs work» Needs review

Added the access modifiers.

StatusFileSize
new2.4 KB
PASSED: [[SimpleTest]]: [MySQL] 57,334 pass(es).
[ View ]

Wrong post. Please ingore. #5 is the correct one.

Status:Needs review» Needs work

@tvlooy Please resubmit the correct patch. This will reduce confusion for the person who is approving the patches to be moved into core.

Thanks

Assigned:Unassigned» danylevskyi
Issue tags:+CodeSprintUA

Assigned:danylevskyi» Unassigned
Status:Needs work» Needs review
StatusFileSize
new6.18 KB
PASSED: [[SimpleTest]]: [MySQL] 56,068 pass(es).
[ View ]

Status:Needs review» Reviewed & tested by the community

#10 nice conversion
RTBC

Applies cleanly and all occurrences of title_query are now changed.

Title:Rename Views method title_query() to titleQuery()Change notice: Rename Views method title_query() to titleQuery()
Project:Drupal core» Views
Version:8.x-dev» 8.x-3.x-dev
Component:views.module» Code
Status:Reviewed & tested by the community» Active
Issue tags:+Needs change record

Committed and pushed to 8.x. Thanks!

Moving to the Views queue for the change notice.

Title:Change notice: Rename Views method title_query() to titleQuery()Rename Views method title_query() to titleQuery()
Project:Views» Drupal core
Version:8.x-3.x-dev» 8.x-dev
Component:Code» views.module
Status:Active» Fixed
Issue tags:-Needs change record

Single change notice in the meta.

Automatically closed -- issue fixed for 2 weeks with no activity.