Files: 
CommentFileSizeAuthor
#8 2002980-rename-summary_query.patch3.32 KBsillygwailo
PASSED: [[SimpleTest]]: [MySQL] 57,176 pass(es).
[ View ]
#3 2002980-3-rename_summaryQuery.patch3.25 KBGang Wang
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git].
[ View ]

Comments

Assigned:Unassigned» hansenm

Assigned:hansenm» Gang Wang

I take this task.

Gang Wang
SUNY Geneseo

Status:Active» Needs review
StatusFileSize
new3.25 KB
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git].
[ View ]

Uploading patch.

Status:Needs review» Needs work

The last submitted patch, 2002980-3-rename_summaryQuery.patch, failed testing.

Status:Needs work» Needs review

All these functions should start with "protected function ...". They are used internally by argument plugins.

Status:Needs review» Needs work

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/argument/ArgumentPluginBase.phpundefined
@@ -803,7 +803,7 @@ function default_summary() {
+  function summaryQuery() {
+++ b/core/modules/views/lib/Drupal/views/Plugin/views/argument/Formula.phpundefined
@@ -45,7 +45,7 @@ function get_formula() {
+  function summaryQuery() {
+++ b/core/modules/views/lib/Drupal/views/Plugin/views/argument/ManyToOne.phpundefined
@@ -161,7 +161,7 @@ function title() {
+  function summaryQuery() {
+++ b/core/modules/views/lib/Drupal/views/Plugin/views/argument/String.phpundefined
@@ -146,7 +146,7 @@ public function buildOptionsForm(&$form, &$form_state) {
+  function summaryQuery() {

Add protected access modifier in front of the functions to adhere to the new OOP standards.

Status:Needs work» Needs review
StatusFileSize
new3.32 KB
PASSED: [[SimpleTest]]: [MySQL] 57,176 pass(es).
[ View ]

Re-roll with protected.

Status:Needs review» Needs work
Issue tags:-Novice, -VDC

The last submitted patch, 2002980-rename-summary_query.patch, failed testing.

Status:Needs work» Needs review
Issue tags:+Novice, +VDC

#8: 2002980-rename-summary_query.patch queued for re-testing.

Status:Needs review» Reviewed & tested by the community

Status:Reviewed & tested by the community» Fixed

Committed da5a7ff and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.