Files: 
CommentFileSizeAuthor
#5 drupal-rename-summary-basics-2002988-5.patch2.72 KBtvlooy
PASSED: [[SimpleTest]]: [MySQL] 57,475 pass(es).
[ View ]
#3 drupal-rename-summary-basics-2002988-3.patch2.72 KBkenianbei
PASSED: [[SimpleTest]]: [MySQL] 55,895 pass(es).
[ View ]

Comments

Assigned:Unassigned» kenianbei

Status:Active» Needs review
StatusFileSize
new2.72 KB
PASSED: [[SimpleTest]]: [MySQL] 55,895 pass(es).
[ View ]

First patch for drupal core, whoop!

Status:Needs review» Needs work

@kenianbei, thanks for contributing. You need to add the access modifier (public/private/protected) before the function name. Take a look at the parent issue (http://drupal.org/node/1856630), comments #28, #34, #35 for more details.

You can see an example patch here: http://drupal.org/node/2001672

Status:Needs work» Needs review
StatusFileSize
new2.72 KB
PASSED: [[SimpleTest]]: [MySQL] 57,475 pass(es).
[ View ]

Added the access modifier.

Status:Needs review» Reviewed & tested by the community

Looks good.

Reviewed patch based on the following criteria: http://drupal.org/node/1856630#comment-7450696

Status:Reviewed & tested by the community» Fixed

Committed 4547223 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.