Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | drupal_rename_summary_argument-2003238-9.patch | 4.77 KB | nathangervais |
| #2 | drupal.summary_argument-2003238.patch | 3.26 KB | nathangervais |
Comments
Comment #1
nathangervais CreditAttribution: nathangervais commentedComment #2
nathangervais CreditAttribution: nathangervais commentedComment #3
craychee CreditAttribution: craychee commentedAdds public. All functions changed. Nice work.
Comment #5
nathangervais CreditAttribution: nathangervais commented#2: drupal.summary_argument-2003238.patch queued for re-testing.
Comment #7
SpartyDan CreditAttribution: SpartyDan commented#2: drupal.summary_argument-2003238.patch queued for re-testing.
Comment #8
oenie CreditAttribution: oenie commentedHate to throw this back, but it seems some replacements have been missed:
core/modules/views/views.theme.inc, line 436:
$row_args[$id] = $argument->summary_argument($row);
core/modules/views/views.theme.inc, line 496:
$row_args[$id] = $argument->summary_argument($row);
Comment #9
nathangervais CreditAttribution: nathangervais commentedRight your are, appears my search missed that file, i've rerolled the patch from the latest HEAD, and also updated a comment referring to summary_argument.
Comment #10
aspilicious CreditAttribution: aspilicious commentedLooking good
Comment #11
alexpottCommitted f6ea9cd and pushed to 8.x. Thanks!