Files: 
CommentFileSizeAuthor
#15 renamed-store-group-input-2003240-15.patch1.48 KBtheladebug
PASSED: [[SimpleTest]]: [MySQL] 56,392 pass(es).
[ View ]
#11 renamed-store-group-input-2003240-11.patch1.48 KBtheladebug
FAILED: [[SimpleTest]]: [MySQL] Fetch test patch: failed to retrieve [renamed-store-group-input-2003240-11.patch] from [drupal.org].
[ View ]
#4 drupal-store-group-input-2003240-2.patch1.48 KBgdf
PASSED: [[SimpleTest]]: [MySQL] 55,734 pass(es).
[ View ]
#3 drupal-store-group-input-2003240-1.patch1.48 KBgdf
FAILED: [[SimpleTest]]: [MySQL] Invalid PHP syntax in core/modules/views/lib/Drupal/views/Plugin/views/filter/FilterPluginBase.php.
[ View ]
#2 drupal-store-group-input-2003240.patch1.47 KBgdf
FAILED: [[SimpleTest]]: [MySQL] 56,603 pass(es), 2 fail(s), and 0 exception(s).
[ View ]

Comments

Assigned:Unassigned» gdf

Status:Active» Needs review
StatusFileSize
new1.47 KB
FAILED: [[SimpleTest]]: [MySQL] 56,603 pass(es), 2 fail(s), and 0 exception(s).
[ View ]

StatusFileSize
new1.48 KB
FAILED: [[SimpleTest]]: [MySQL] Invalid PHP syntax in core/modules/views/lib/Drupal/views/Plugin/views/filter/FilterPluginBase.php.
[ View ]

forgot to add "public" to method

StatusFileSize
new1.48 KB
PASSED: [[SimpleTest]]: [MySQL] 55,734 pass(es).
[ View ]

changed "publi" to "public", note to myself not to borrow cheesy mac from friend next DrupalCon

Status:Needs review» Reviewed & tested by the community

Ran successful test creating a view.

I did not find any occurrence of the store_group_input in core after applying the patch in #4.

Status:Reviewed & tested by the community» Needs work
Issue tags:-Novice, -VDC

The last submitted patch, drupal-store-group-input-2003240-2.patch, failed testing.

Status:Needs work» Needs review
Issue tags:+Novice, +VDC

Assigned:gdf» Unassigned

retest was successful - code is not related, and it was a very, very busy day for testBot

Status:Needs review» Needs work

Unfortunately we need a reroll, the patch doesn't apply anymore.

Status:Needs work» Needs review
StatusFileSize
new1.48 KB
FAILED: [[SimpleTest]]: [MySQL] Fetch test patch: failed to retrieve [renamed-store-group-input-2003240-11.patch] from [drupal.org].
[ View ]

Status:Needs review» Needs work
Issue tags:-Novice, -VDC

The last submitted patch, renamed-store-group-input-2003240-11.patch, failed testing.

Status:Needs work» Needs review
Issue tags:+Novice, +VDC

Status:Needs review» Needs work

You need to reroll your patch i don't think it applies anymore. (due to all the views patches getting in)

Status:Needs work» Needs review
StatusFileSize
new1.48 KB
PASSED: [[SimpleTest]]: [MySQL] 56,392 pass(es).
[ View ]

rerolled patch

Status:Needs review» Reviewed & tested by the community

Great!

Status:Reviewed & tested by the community» Fixed

Committed 5e0590c and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.